Skip to content

Conversation

@thenora
Copy link

@thenora thenora commented Feb 5, 2020

I've made tweaks this morning that I need to clean up, but I'm submitting to practice submitting.

Assignment Submission: Calculator

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions:

Reflection

Question Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking? I think my indentation, spacing, and variable names were all good.
How did your code keep track of user input? I used variables to keep track of user input.
How did your code determine what operation to perform? I gathered user input for the operation, compared it against my list, and then used case to determine the math.
What opportunities exist to create small methods for this project? validate is a good opportunity for a method.
In the next project, what would you change about your process? What would you keep doing? I rabbit-holed for about 2+ hours last night and ended up trashing my revised code and going back to where I was when I left class yesterday. I was trying to get too far ahead of myself and combine methods and nested arrays inside of hashes. Actually doing a rough paper sketch of psuedo code would have helped me organize what I actually wanted to do.

I've made tweaks this morning that I need to clean up, but I'm submitting to practice submitting.
Fixed errors I'd introduced this morning
@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly uses conditionals (if/else/elsif) ✔️
Correctly uses loops (while/until) ✔️
Correctly uses gets.chomp ✔️
Correctly uses variables ✔️
Correctly creates and uses custom methods ✔️

Functional Requirements

Functional Requirement yes/no
User can input two numbers and an operator and perform addition ✔️
User can input in two numbers and an operator and can perform subtraction ✔️
User gets feedback from the CLI when attempting to divide by zero, and the program does not give an error Yes, but it also errors out when the numerator is 0, though it shouldn't. (0/2 = 0, not undefined)

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 3+ in Code Review && 2+ in Functional Requirements ✔️
Yellow (Approaches Standards) 2 in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants