Space - Kate Mangubat

[katemyer]

Calculator project from day 2

Assignment Submission: Calculator

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions:

Reflection

Question	Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking?	I feel like indentation was correct for each block of code. The variable names were possibly long but distinguishable for me to follow the logic of my code.
How did your code keep track of user input?	I store the first number and second number using gets.chomp.to_i
How did your code determine what operation to perform?	This code utilized methods to validate and calculate the numbers entered by the user.
What opportunities exist to create small methods for this project?	There were a few opportunities where code was being repeated. For example, the user selecting the operator they wanted to use, performing the math operation, and validating user number to make sure they didn't use "fart" as an input.
In the next project, what would you change about your process? What would you keep doing?	I would let the question sink in for a little bit and use paper/pencil to draw out what I need to do. From there, I would review what we have done in the lesson to make sure I'm able to transfer the lesson to the example. I will write the code first and then go back and determine how to make it better rather than try to make it good right off the bat. I will also breathe and let the process come to be instead of worrying that I can't keep up with my classmates. Take a walk, stretch, and regroup my thinking.

[CheezItMan]

Calculator

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly uses conditionals (if/else/elsif)	✔️
Correctly uses loops (while/until)	✔️
Correctly uses gets.chomp	✔️
Correctly uses variables	✔️
Correctly creates and uses custom methods	✔️ You made the methods nicely, but name them in snake_case.

Functional Requirements

Functional Requirement	yes/no
User can input two numbers and an operator and perform addition	✔️
User can input in two numbers and an operator and can perform subtraction	✔️
User gets feedback from the CLI when attempting to divide by zero, and the program does not give an error	⚠ This gives us infinity if they try to divide by 0.

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	3+ in Code Review && 2+ in Functional Requirements	✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	⚠ almost perfect, just a bit in the case.
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

Summary

Nicely done, you hit the learning goals here. This makes a great start here at Ada.

[katemyer]

Re: ⚠ This gives us infinity if they try to divide by 0.
Is returning infinity incorrect since the instructions requires that the program does not give an error?