Space - Yieni

[yieknee]

Assignment Submission: Calculator

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions:

Reflection

Question	Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking?	I think my my code is readable, although I could have commented on my code more for increased readability.
How did your code keep track of user input?	My code kept track of user input through get requests stored in variables.
How did your code determine what operation to perform?	My code determined what operations to perform using case/when. If the user's input matched the when statement it used the methods I wrote to execute the computations. If user input didn't match, there is a when option that outputs a message for invalidity.
What opportunities exist to create small methods for this project?	I created methods for executing the operations, and a method to terminate the program if the user input was invalid. I could possibly have written a method to collect the user input for the numbers they wanted to calculate.
In the next project, what would you change about your process? What would you keep doing?	I would take more time to comment on my code.

[jmaddox19]

Calculator

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly uses conditionals (if/else/elsif)	✔️
Correctly uses loops (while/until)	No, instead of re-asking for the user to input valid data, the program just quits if the user inputs invalid data
Correctly uses gets.chomp	✔️
Correctly uses variables	✔️
Correctly creates and uses custom methods	✔️

Functional Requirements

Functional Requirement	yes/no
User can input two numbers and an operator and perform addition	✔️
User can input in two numbers and an operator and can perform subtraction	✔️
User gets feedback from the CLI when attempting to divide by zero, and the program does not give an error	✔️

Overall Feedback

Good work overall. A couple comments:

1. One of the expectations was that the program re-prompt the user if the input is invalid.
2. The program doesn't seem to handle negative numbers

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	3+ in Code Review && 2+ in Functional Requirements	✔️
Yellow (Approaches Standards)	2 in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

[jmaddox19]

Sorry about my misunderstanding of the instructions! Please ignore #1 above!