Space - Jeta #48
Open
Space - Jeta #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Day 2 - Ada Homework - Calculator
This is my first draft and I upload my second one alredy.
Modify line nr 26
CalculatorMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
SummaryNice work, you hit the learning goals here. I like your methods, they work quite well. However you should work to properly indent code. |
CheezItMan
reviewed
Feb 7, 2020
| result = ((num_one.to_f) * (num_two.to_f)).round(2) | ||
| elsif math_operation == "Divide" || math_operation == "/" | ||
| result = ((num_one.to_f) / (num_two.to_f)).round(2) | ||
| end |
There was a problem hiding this comment.
indentation
Suggested change
| end | |
| end |
Comment on lines
+16
to
+22
| def ValidOperator (math_operation) | ||
| until ["Add","+", "Subtract","-", "Multiply", "*", "Divide", "/"].include? math_operation | ||
| puts "Enter a valid selection" | ||
| math_operation = gets.chomp | ||
| end | ||
| return math_operation | ||
| end |
Comment on lines
+27
to
+29
| puts "Enter a valid number" | ||
| number = gets.chomp.to_i | ||
| end |
| @@ -0,0 +1,56 @@ | |||
| #Add,Subtract,Multiply,Divide Methode | |||
| def operation(num_one, math_operation, num_two) | |||
| if math_operation == "Add" || math_operation == "+" | |||
There was a problem hiding this comment.
I suggest capitalizing math_operation, before starting these if-elsif comparisons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Calculator
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions:
Reflection