forked from AdaGold/hash-practice
-
Notifications
You must be signed in to change notification settings - Fork 41
space kate #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
katemyer
wants to merge
1
commit into
Ada-C13:master
Choose a base branch
from
katemyer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
space kate #27
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,20 +1,67 @@ | ||||||
|
|
||||||
| # This method will return an array of arrays. | ||||||
| # Each subarray will have strings which are anagrams of each other | ||||||
| # Time Complexity: ? | ||||||
| # Space Complexity: ? | ||||||
| # Time Complexity: O(n log n) | ||||||
| # Space Complexity: O(n) | ||||||
|
|
||||||
| def grouped_anagrams(strings) | ||||||
| raise NotImplementedError, "Method hasn't been implemented yet!" | ||||||
| end | ||||||
| # create an empty hash to store your word | ||||||
| hash = {} | ||||||
|
|
||||||
| #loop through strings | ||||||
| strings.each do |word| | ||||||
| key = word.chars.sort.join | ||||||
| #check if key is in the hash, push the word into the hash | ||||||
| #else, set the key as the word | ||||||
| if hash.key?(key) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a bit more compact.
Suggested change
|
||||||
| hash[key] << word | ||||||
| else | ||||||
| hash[key] = [word] | ||||||
| end | ||||||
| end | ||||||
| #create a new result array | ||||||
| #loop through hash to get the keys | ||||||
| result = [] | ||||||
| hash.each do | key, value | | ||||||
| result << hash[key] | ||||||
| end | ||||||
|
|
||||||
| #return the array | ||||||
| return result | ||||||
| end #end function | ||||||
|
|
||||||
|
|
||||||
| # This method will return the k most common elements | ||||||
| # in the case of a tie it will select the first occuring element. | ||||||
| # Time Complexity: ? | ||||||
| # Space Complexity: ? | ||||||
| # list = [1,1,1,1,2] | ||||||
| #outcome = 1 | ||||||
| # Time Complexity: O(n log n) | ||||||
| # Space Complexity: O(n) | ||||||
| def top_k_frequent_elements(list, k) | ||||||
|
Comment on lines
+38
to
40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||
| raise NotImplementedError, "Method hasn't been implemented yet!" | ||||||
| end | ||||||
| #check if the length of the list is zero, return empty array | ||||||
| if list.length == 0 | ||||||
| return [] | ||||||
| end | ||||||
| #create new hash here | ||||||
| hash = Hash.new(0) | ||||||
| #loop through array | ||||||
| list.each do |num| | ||||||
| hash[num] += 1 | ||||||
| end | ||||||
| #got help with this result line via Martha | ||||||
| #you want to sort the hash by number value and frequency | ||||||
| #descending order | ||||||
| result = hash.sort_by{|num, frequency| -frequency} | ||||||
| #create an empty array to hold your final result | ||||||
| final_result = [] | ||||||
| #based on the number of common elements you want, that's how many times you'll loop thorugh | ||||||
| #push the result into the final result | ||||||
| #return the final result | ||||||
| k.times do |i| | ||||||
| final_result << result[i][0] | ||||||
| end | ||||||
| return final_result | ||||||
| end #end function | ||||||
|
|
||||||
|
|
||||||
| # This method will return the true if the table is still | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're sorting the words and English words are small this method actually depends on the number of words, not the length of them.
So it's O(n * m log m) where m is the length of the words, or if you assume the words are short O(n)