Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions lib/heap_sort.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@


# This method uses a heap to sort an array.
# Time Complexity: ?
# Space Complexity: ?
def heap_sort(list)
raise NotImplementedError, "Method not implemented yet..."
# Time Complexity: O(n log n)
# Space Complexity: O(n)
def heapsort(list)
Comment on lines +4 to +6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

heap = MinHeap.new

list.each do |num|
heap.add(num)
end

result = []
i = 0
while i < list.length
result << heap.remove()
i += 1
end

return result
end
63 changes: 50 additions & 13 deletions lib/min_heap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,26 @@ def initialize
end

# This method adds a HeapNode instance to the heap
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n)
# Space Complexity: O(log n)
def add(key, value = key)
Comment on lines +17 to 19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , nice catch on the space complexity incurred from recursion.

raise NotImplementedError, "Method not implemented yet..."
@store << HeapNode.new(key, value)
heap_up(@store.length - 1)
end

# This method removes and returns an element from the heap
# maintaining the heap structure
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n)
# Space Complexity: O(log n)
def remove()
Comment on lines +26 to 28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
# min heap always remove the smallest element
return nil if @store.empty?
# swap it with the last node, so we can just pop off the last node in the heap
swap(0, @store.length - 1)
result = @store.pop

heap_down(0) unless @store.empty?
return result.value
end


Expand All @@ -44,28 +52,57 @@ def to_s
end

# This method returns true if the heap is empty
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(1)
# Space complexity: O(1)
def empty?
Comment on lines +55 to 57

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
return @store.empty?
end

private

# This helper method takes an index and
# moves it up the heap, if it is less than it's parent node.
# It could be **very** helpful for the add method.
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(log n)
# Space complexity: O(log n)
def heap_up(index)
Comment on lines +66 to 68

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


return if index == 0 # root node
# compare the new node with its parent
# if out of order, swap
parent = (index - 1) / 2
if @store[index].key < @store[parent].key
swap(index, parent)
heap_up(parent)
end
return
end

# This helper method takes an index and
# moves it up the heap if it's smaller
# than it's parent node.
def heap_down(index)
Comment on lines 80 to 83

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
# will stop when it reached the leave node

return if index == @store.length
left_child = 2 * index + 1
right_child = 2 * index + 2
# compare to the smallest child for min heap
if right_child < @store.length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to check to see if the right child is past the end of the array.

if @store[left_child].key > @store[right_child].key
smallest_child = right_child
else
smallest_child = left_child
end

if @store[index].key > @store[smallest_child].key
swap(index, smallest_child)
heap_down(smallest_child)
end
elsif left_child < @store.length
if @store[index].key > @store[left_child].key
swap(index, left_child)
end
end
end

# If you want a swap method... you're welcome
Expand Down
2 changes: 1 addition & 1 deletion test/heapsort_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "heapsort" do
describe "heapsort" do
it "sorts an empty array" do
# Arrange
list = []
Expand Down