-
Notifications
You must be signed in to change notification settings - Fork 41
space katem #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
space katem #25
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,22 @@ | ||
|
|
||
|
|
||
| # This method uses a heap to sort an array. | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: ? n log(n) | ||
| # Space Complexity: ? O(n) | ||
| def heapsort(list) | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| # raise NotImplementedError, "Method not implemented yet..." | ||
| #initialize | ||
| heap_sort = MinHeap.new() | ||
| #loop through list | ||
| list.each do |number| | ||
| # add values into new heap | ||
| heap_sort.add(number, number) | ||
| end | ||
| #create a new array that will be sorted | ||
| sorted_array = Array.new | ||
| #until the heap is empty | ||
| until heap_sort.empty? | ||
| #push values into sorted array while removing from heap | ||
| sorted_array << heap_sort.remove | ||
| end | ||
| end | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -14,18 +14,29 @@ def initialize | |||||||||||||
| end | ||||||||||||||
|
|
||||||||||||||
| # This method adds a HeapNode instance to the heap | ||||||||||||||
| # Time Complexity: ? | ||||||||||||||
| # Space Complexity: ? | ||||||||||||||
| # Time Complexity: ? O(logn) | ||||||||||||||
| # Space Complexity: ? O(1) | ||||||||||||||
| def add(key, value = key) | ||||||||||||||
|
Comment on lines
+17
to
19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 However since you are doing recursion the space complexity is O(log n) due to the call stack. |
||||||||||||||
| raise NotImplementedError, "Method not implemented yet..." | ||||||||||||||
| #pushing key value of node into the store array | ||||||||||||||
| @store << HeapNode.new(key, value) | ||||||||||||||
| # add | ||||||||||||||
| heap_up(@store.length - 1) | ||||||||||||||
| end | ||||||||||||||
|
|
||||||||||||||
| # This method removes and returns an element from the heap | ||||||||||||||
| # maintaining the heap structure | ||||||||||||||
| # Time Complexity: ? | ||||||||||||||
| # Space Complexity: ? | ||||||||||||||
| # Time Complexity: O(logn) | ||||||||||||||
| # Space Complexity: O(1) | ||||||||||||||
| def remove() | ||||||||||||||
|
Comment on lines
+28
to
30
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 However since you are doing recursion the space complexity is O(log n) due to the call stack. |
||||||||||||||
| raise NotImplementedError, "Method not implemented yet..." | ||||||||||||||
| #set root to first element of the store array | ||||||||||||||
| root = @store[0] | ||||||||||||||
| #swpap | ||||||||||||||
| swap(0, @store.length - 1) | ||||||||||||||
| # take it out | ||||||||||||||
| @store.pop() | ||||||||||||||
| #eventually remove | ||||||||||||||
| heap_down(0) | ||||||||||||||
| return root.value | ||||||||||||||
| end | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
|
|
@@ -44,28 +55,55 @@ def to_s | |||||||||||||
| end | ||||||||||||||
|
|
||||||||||||||
| # This method returns true if the heap is empty | ||||||||||||||
| # Time complexity: ? | ||||||||||||||
| # Space complexity: ? | ||||||||||||||
| # Time complexity: O(1) | ||||||||||||||
| # Space complexity: O(1) | ||||||||||||||
| def empty? | ||||||||||||||
| raise NotImplementedError, "Method not implemented yet..." | ||||||||||||||
| return @store.length == 0 | ||||||||||||||
| end | ||||||||||||||
|
|
||||||||||||||
| private | ||||||||||||||
|
|
||||||||||||||
| # This helper method takes an index and | ||||||||||||||
| # moves it up the heap, if it is less than it's parent node. | ||||||||||||||
| # It could be **very** helpful for the add method. | ||||||||||||||
| # Time complexity: ? | ||||||||||||||
| # Space complexity: ? | ||||||||||||||
| # Time complexity: O(logn) | ||||||||||||||
| # Space complexity: O(1) | ||||||||||||||
| def heap_up(index) | ||||||||||||||
|
|
||||||||||||||
| if index == 0 | ||||||||||||||
| return | ||||||||||||||
| end | ||||||||||||||
| parent_index = ((index -1 )/2).floor() | ||||||||||||||
| if @store[index].key < @store[parent_index].key | ||||||||||||||
| swap(index, parent_index) | ||||||||||||||
| heap_up(parent_index) | ||||||||||||||
| end | ||||||||||||||
| end | ||||||||||||||
|
|
||||||||||||||
| # This helper method takes an index and | ||||||||||||||
| # moves it up the heap if it's smaller | ||||||||||||||
| # than it's parent node. | ||||||||||||||
| def heap_down(index) | ||||||||||||||
| raise NotImplementedError, "Method not implemented yet..." | ||||||||||||||
| if index >= @store.length | ||||||||||||||
| return | ||||||||||||||
| end | ||||||||||||||
|
|
||||||||||||||
| left_child_index = (2 * index + 1) | ||||||||||||||
| right_child_index = (2 * index + 2) | ||||||||||||||
|
|
||||||||||||||
| if left_child_index >= @store.length | ||||||||||||||
| return | ||||||||||||||
| elsif right_child_index >= @store.length | ||||||||||||||
| return | ||||||||||||||
| end | ||||||||||||||
|
Comment on lines
+95
to
+97
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if the left child index is less than the length and the value at the left child index is less than the current parent!
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| if @store[index].key > @store[left_child_index].key | ||||||||||||||
| swap(index, left_child_index) | ||||||||||||||
| heap_down(left_child_index) | ||||||||||||||
| end | ||||||||||||||
| if @store[index].key > @store[right_child_index].key | ||||||||||||||
| swap(index, right_child_index) | ||||||||||||||
| heap_down(right_child_index) | ||||||||||||||
| end | ||||||||||||||
| end | ||||||||||||||
|
|
||||||||||||||
| # If you want a swap method... you're welcome | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍