Time - Lola #38

ubeninja77 · 2020-03-09T18:07:05Z

Assignment Submission: Hotel

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question	Answer
What was a design challenge that you encountered on this project?	I originally had another design in mind. so going from a made from scratch to making sure I pasts test someone else made threw me for a loop. Looking back, I could have omitted a Class to work with only two.
What was a design decision you made that changed over time over the project?	I had to look into Wave 2 and decide how I wanted to handle making and storing a reservation in Wave 1
What was a concept you gained clarity on, or a learning that you'd like to share?	Making and understanding the variable in my before blocks in my tests. I knew I wanted to add a few tests to practice.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	In the available rooms method, testing to check if a room has a current reservation and then making sure that room is not included in the returned array. A nominal test case because it wills have to run to check if a room is reserved.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	In the DateRange class, I added a DatetError if the start/end date overlap. It will raise and error if the dates are invalid and tells the user why it failed.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I'm slowly getting used to it. I find myself writing mini code i.e # i want to raise ArgumentError "wrong date" here. I'm still telling myself not to become frustrated if the I run a test and it doesn't pass, to deviate from writing pseudocode. Or that the pseudocode is not final, it can be changed.

…by_date method to answer wave 2 questions.

… room and storing a reservation

…om, rervervation_by_date and available_room. passed wave 1 and 2

beccaelenzil · 2020-03-13T14:17:12Z

test/date_range_test.rb

      end_date = @range.end_date
      test_range = Hotel::DateRange.new(start_date, end_date)

      expect(@range.overlap?(test_range)).must_equal true


This is a good test for a single test case. The test cases below also need to be completed to insure that .overlap? returns the correct value for the different situations described below.

beccaelenzil · 2020-03-13T14:21:11Z

test/hotel_controller_test.rb

    @date = Date.parse("2020-08-04")
  end
  describe "wave 1" do
-    describe "rooms" do


You should keep this test to ensure that a hotel_controller has an array of rooms.

beccaelenzil · 2020-03-13T14:21:56Z

lib/hotel_controller.rb


-    def reservations(date)
-      return []
+    def initialize()


This constructor looks great. Make sure to include a test that check that the class is set up correctly.

beccaelenzil · 2020-03-13T14:25:00Z

test/hotel_controller_test.rb

-      end
-    end
    describe "reserve_room" do
      it "takes two Date objects and returns a Reservation" do


This is a good test. Nice work! You also need to test edge cases. What if there is no room available?

beccaelenzil · 2020-03-13T14:27:25Z

test/reservation_test.rb

+      room_number = 7
+      rate = 200
+      reservation = Hotel::Reservation.new(start_date, end_date, room_number, rate)
      expect(reservation.cost).must_be_kind_of Numeric


In addition to checking that cost is Numeric you should check that it is the correct value.

beccaelenzil · 2020-03-13T14:33:31Z

lib/hotel_controller.rb

-      return []
+    # Wave 1
+    # creates a reservation of a room for a given date range
+    def reserve_room(start_date, end_date, room_number, rate)


Nice work implementing this complex logic. To fully tie together reserve_room and available_rooms, ideally reserve_room would not take a room_number as an argument, but instead find an available room by using the available_rooms method.

beccaelenzil · 2020-03-13T14:34:18Z

lib/refactors.txt

+Raise more exceptions to account for user input error
+I would consider trying to make more helper methods 
+Save the reservations and it's room number in a array of hashes
+Get better at writing tests


Your tests look great! However, you need more of them.

beccaelenzil · 2020-03-13T14:35:09Z

lib/refactors.txt

+I would consider trying to make more helper methods 
+Save the reservations and it's room number in a array of hashes
+Get better at writing tests
+Understand how to get the program to pass 95% test coverage


By clicking on the file name in the index.html file in the coverage directory, you can see which lines of code weren't tested.

beccaelenzil · 2020-03-13T14:37:34Z

test/date_range_test.rb

  end

-  xdescribe "include?" do
+  describe "include?" do


The tests below should be completed. This will bring up you test coverage for DateRange

beccaelenzil · 2020-03-13T14:40:07Z

Hotel

Section 1: Major Learning Goals

Criteria	yes/no, and optionally any details/lines of code to reference
Practices SRP by having at least two separate classes with distinct responsibilities, and test files for these two classes	✔️
Overall, demonstrates understanding instance variables vs. local variables. (There aren't unnecessarily too many instance variables, when it should be a local variable)	✔️
For each test file, tests demonstrate an understanding of instantiating objects properly, and using Arrange-Act-Assert	✔️
Practices pseudocode and TDD, and reflected on it by filling out the reflection questions	✔️
Practices git with at least 15 small commits and meaningful commit messages	✔️

Section 2: Code Review and Testing Requirements

Criteria	yes/no, and optionally any details/lines of code to reference
There is a class that represents a reservation, and a second class that holds/manages a collection of reservations through composition (instance variable)	✔️
The logic for checking if a reservation's date overlaps with another reservation's date is complex logic that is separated into method(s) (and potentially class(es))	✔️
The logic for checking if a reservation's date overlaps with another reservation's date has unit tests	These tests are incomplete. See inline comment.
All of the given tests run and pass	✔️
A test coverage tool is installed and used, and shows 95% test coverage	Good work installing and using this tool. Note that it shows that `Date_Range` and `Hotel_Controller` have insufficient coverage.

Section 3: Feature Requirements

Feature Requirement: There is a method that...	yes/no
gives back a list of rooms, and it's tested	There is no test for this. See in-line comment
creates a specific reservation for a room for a given date range, and it has nominal test cases	✔️
creates a specific reservation for a room for a given date range, and it tests an edge case, such as no available room, or invalid date range	Edge cases are not tests. See in-line comment.
gives back a list of reservations on a given date. Its tests include a test that makes several reservations for a given date	There is only a test for making a single reservation
calculates the total price for a reservation	✔️
gives back a list of available rooms for a given date range, and it has nominal test cases	✔️
gives back a list of available rooms for a given date range, and it has edge test cases, such as no available room, or invalid date range	Good work testing that it gives all the available rooms when there are not reservations, and reduces this number when there is a reservation. You also need to test edge cases such as no available rooms or invalid date range.
creates a block of rooms	Not required per LP
reserves a room from a block	No required per LP

Overall Feedback

Overall Feedback	Criteria	yes/no
Yellow (Approaches Standards)	9-13 total in all sections

Additional Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

I am particularly impressed by the way that you worked through complex logic to create helper methods such as available rooms and overlap?. Furthermore, the hotel project is a complex system, and you are clearly meeting the learning goals of using object composition.

I do see some room for improvement around writing comprehensive tests that test multiple nominal and edge cases. I recommend using the coverage report to identify lines of code that haven't been tested. If you're not sure how to address these lines of code, talk to an instructor or TA.

Keep up the hard work!

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Elegant/Clever	✅
Descriptive/Readable	✅
Logical/Organized	✅

ubeninja77 added 23 commits March 3, 2020 10:53

added method to list rooms

49a7e14

added initialize and attr_accessors

099e747

test to see where this is being uploaded to

4c1474b

added helper method and added initialize method'

61aff24

added helper method, initialized method, rooms method

d8b5910

fixed reservations method

3289c83

updated initialize method end/start date

c2fd43e

rewrote nights method

93cc55f

updated cost method (rate)

6eb8dfb

updated nights method

0c7322c

rewrote rooms and reserve rooms method. updating avail rooms and res_…

a471fb7

…by_date method to answer wave 2 questions.

refactored tests to account for room number and rate when reserving a…

95f324c

… room and storing a reservation

updated attr_accessor and nights method

9cfb144

cleaned up the attr_reader and added date_range as a instance variable

ae9df64

tests pass wave 1 but refactoring wave 2 to up my test coverage %

df966d7

rewrote overlap method, passed wave 1 and 2

fe360c1

passed wave 1 and 2

65a8b36

added hotel rooms array into initialize method, refactored reserve_ro…

db6dc08

…om, rervervation_by_date and available_room. passed wave 1 and 2

passed wave 1 and 2

e3c4ea4

passed wave 1 and 2

6c14d91

added my thoughts for future changes and refactoring

eb7f899

added one more thought and future plan

a131840

test helper with simplecov

2566193

ubeninja77 changed the title ~~Design scaffolding~~ Time - Lola Mar 11, 2020

beccaelenzil reviewed Mar 13, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Time - Lola #38

Time - Lola #38

Uh oh!

ubeninja77 commented Mar 9, 2020

Uh oh!

beccaelenzil Mar 13, 2020

Uh oh!

beccaelenzil Mar 13, 2020

Uh oh!

beccaelenzil Mar 13, 2020

Uh oh!

beccaelenzil Mar 13, 2020

Uh oh!

beccaelenzil Mar 13, 2020

Uh oh!

beccaelenzil Mar 13, 2020

Uh oh!

beccaelenzil Mar 13, 2020

Uh oh!

beccaelenzil Mar 13, 2020

Uh oh!

beccaelenzil Mar 13, 2020

Uh oh!

beccaelenzil commented Mar 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Time - Lola #38

Are you sure you want to change the base?

Time - Lola #38

Uh oh!

Conversation

ubeninja77 commented Mar 9, 2020

Assignment Submission: Hotel

Reflection

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beccaelenzil commented Mar 13, 2020

Hotel

Section 1: Major Learning Goals

Section 2: Code Review and Testing Requirements

Section 3: Feature Requirements

Overall Feedback

Additional Feedback

Code Style Bonus Awards

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants