space - Yieni & Cathy by yieknee · Pull Request #16 · Ada-C13/oo-ride-share

yieknee · 2020-02-29T00:22:14Z

Assignment Submission: OO Ride Share

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question	Answer
How did getting up to speed on the existing codebase go? If it went well, what worked? If it didn't go well, what will you do differently next time?	We read through each class to see if we understood what was happening. What didn't work was starting at the abstract class. We also visually mapped out the interactions.
What inheritance relations exist between classes?	Driver, Passenger, and Trip are subclasses of CSVRecord. TripDispatcher is its own class. We also created our own error that is a child of the StandardError Class.
What composition relations exist between classes?	TripDispatcher is the driver code that connects the various classes.
Describe a decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	We wanted to decide how to handle the situation where no drivers are available, thus we created a NoDriverError that inherited from the StandardError class.
Give an example of a template method that you implemented for this assignment	self.from_csv(record)
Give an example of a nominal test that you wrote for this assignment	calculating the right float for the average rating given trips that had concluded.
Give an example of an edge case test that you wrote for this assignment	return zero if there are no trips.
What is a concept that you gained more clarity on as you worked on this assignment	object and inheritance.

…t file.

…ple tests

…ests

beccaelenzil · 2020-03-12T17:12:39Z

OO Ride Share

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Comprehension Questions	Your answer about composition relationship gets at this. By composition we mean a has-a or has-many relationship. Examples in this project include "a TripDispatcher has-many Drivers, Passengers and Trips", "a Driver has-many Trips", "a Trip has-a Driver".
The code demonstrates individual learning about `Time` and the responsibility of `Trip.from_csv`, and uses `Time.parse` in `Trip.from_csv`	✔️
The code demonstrates breaking out complex logic in helper methods, such as making a helper method in `Trip` to calculate duration	✔️
There are tests for the nominal cases for the `Passenger#net_expenditures` and `Passenger#total_time_spent`	✔️
There is at least one edge case test for either `Passenger#net_expenditures` or `Passenger#total_time_spent` testing if the passenger has no trips	✔️
Practices inheritence. `Driver` inherits from `CsvRecord`, and implements `from_csv`	✔️
Employs problem-solving and implements `Driver#average_rating` and `Driver#total_revenue`	✔️
Implements the `TripDispatcher#request_trip`, which creates an instance of `Trip` with a driver and passenger, adds the new trip to `@trips`, and changes the status of the driver	✔️
Practices composition. In `TripDispatcher#request_trip`, the driver gets connected to the new trip, the passenger gets connected to the new trip	✔️
Practices git with at least 10 small commits and meaningful commit messages	✔️

Testing Requirements

Testing Requirement	yes/no
There is reasonable test coverage for wave 1, and all wave 1 tests pass	✔️
There is reasonable test coverage for wave 2, and all wave 2 tests pass	✔️
Wave 3: Tests in wave 1 and wave 2 explicitly test that only completed trips should be calculated (and ignore in-progress trips)	✔️
There is reasonable test coverage for `TripDispatcher#request_trip`, and all tests pass	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	8+ in Code Review && 3+ in Functional Requirements	✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

beccaelenzil

Great work on this project. The comprehensiveness of your tests is particularly notable. I've left a few in line comments for you to consider, but it is clear that the learning goals around TDD, object composition, and inheritance were met. Keep up the hard work!

beccaelenzil · 2020-03-12T17:08:56Z

lib/trip.rb

+    end
+
+    def duration
+      if end_time != nil


Nice work handling in progress trips across the board (especially testing for this edge case!). I'm not sure if this would make sense with the rest of your implementation, but you might consider whether raising an exception instead of returning a string could work for in progress trips.

beccaelenzil · 2020-03-12T17:09:24Z

test/passenger_test.rb

+      expect(@passenger.total_time_spent).must_equal 4500
+    end
+
+    it "Returns 0 if passenger has no trips" do


Great work testing for these 2 edge cases

beccaelenzil · 2020-03-12T17:10:06Z

lib/driver.rb

+    end
+
+    def total_revenue
+      valid_costs = @trips.reject{|trip|trip.cost == nil}


Good use of an enumerable method

beccaelenzil · 2020-03-12T17:10:52Z

lib/trip_dispatcher.rb

+        end
+      end
+
+      raise NoDriverError.new("Sorry! There are no available drivers. Please request a new trip.") if driver == nil


Good use of a custom exception

beccaelenzil · 2020-03-12T17:11:36Z

lib/trip_dispatcher.rb

+      driver = nil
+      oldest_endtime = Time.now
+
+      available_drivers.each do |indiv_driver|


Good work implementing this logic. You may consider encapsulating this logic in a helper method.

beccaelenzil · 2020-03-12T17:12:30Z

test/trip_dispatch_test.rb

      end
    end
+
+    describe "request_trip(passenger_id)" do


Nice work writing comprehensive tests for this method.

yieknee and others added 10 commits February 25, 2020 15:15

wave 1.1

8dd1fc6

wave 1.2

37f3040

functional code through wave2: loading drivers

ba8cc70

fixed Time class on start and end time. Fixed driver code on trip tes…

92955a0

…t file.

Revised constructor for Driver class and removed driver_id from multi…

3ee715c

…ple tests

Added driver methods for wave 2

9e68536

complete wave 2 through request_trip method w/o writing some of the t…

47af3f7

…ests

Completed wave 3

5a47c91

final working code with optional

1a035d5

cleaned up code

24ac1da

beccaelenzil reviewed Mar 12, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

space - Yieni & Cathy#16

space - Yieni & Cathy#16
yieknee wants to merge 10 commits intoAda-C13:masterfrom
yieknee:master

yieknee commented Feb 29, 2020

Uh oh!

beccaelenzil commented Mar 12, 2020

Uh oh!

beccaelenzil left a comment

Uh oh!

beccaelenzil Mar 12, 2020

Uh oh!

beccaelenzil Mar 12, 2020

Uh oh!

beccaelenzil Mar 12, 2020

Uh oh!

beccaelenzil Mar 12, 2020

Uh oh!

beccaelenzil Mar 12, 2020

Uh oh!

beccaelenzil Mar 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

yieknee commented Feb 29, 2020

Assignment Submission: OO Ride Share

Reflection

Uh oh!

beccaelenzil commented Mar 12, 2020

OO Ride Share

Major Learning Goals/Code Review

Testing Requirements

Overall Feedback

Code Style Bonus Awards

Uh oh!

beccaelenzil left a comment

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Mar 12, 2020

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Mar 12, 2020

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Mar 12, 2020

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Mar 12, 2020

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Mar 12, 2020

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Mar 12, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants