-
Notifications
You must be signed in to change notification settings - Fork 48
Time - Haben #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Time - Haben #37
Conversation
React Tic Tac ToeMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
| id={id} | ||
| value={value} | ||
| onClickCallback={onClickCallback} | ||
| player={player} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a big issue but I wanted to point out that player is being passed as a prop but isn't ever used by the Square component. Its good practice to remove any props that you end up not using (with the exception of key).
This is similar to the advice we'd give about arguments in functions.
|
|
||
| // wave 3 | ||
| const checkForWinner = (squares) => { | ||
| const winningRows = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clever!
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?CS Fundamentals Questions
setState-- it must re-render all of the components that now have different content because of that change.