Skip to content

Conversation

@HabenFoto
Copy link

@HabenFoto HabenFoto commented Apr 20, 2020

React Tic Tac Toe

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt Response
How are events/event handlers and useState connected? Event handlers and useState are connected by a callback function
What are two ways to do "dynamic styling" with React? When should they be used? The two ways to do “dynamic styling” in React is using Inline Styling which is commonly written online (particularly in documentation and tutorials) because it's convenient to condense the code that way and External styling sheet which is done by declaring the styles that need to be used in an external stylesheet.
Much like Rails works with the HTTP request->response cycle, React works with the browser's input->output cycle. Describe React's cycle from receiving user input to outputting different page content. React has event listeners, when react detects events, like button click, it calls a function. And the function can modify state to output different page content.

CS Fundamentals Questions

Question Answer
What do you think is the BigO complexity of the method you use to compute a winner? Time complexity O(n) and space complexity is O(1).
Consider what happens when React processes a state change from setState -- it must re-render all of the components that now have different content because of that change.
What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components? The data structure is DOM (tree structure) Whenever data changes, the entire UI will re-render in a virtual DOM, then it gets compared to what it looked like before. A linear search would better to traverse the components.
Speculate wildly about what the Big-O time complexity of that code might be. Big-O time complexity might be O(n) as it is a linear search.

@jmaddox19
Copy link

React Tic Tac Toe

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Demonstrates proper JavaScript coding style. ✔️
Correctly passes props to child components. ✔️
Correctly passes callback functions to child components and calls them to respond to user events.) ✔️
Maintains the status of the game in state. ✔️
Practices git with at least 6 small commits and meaningful commit messages ✔️
Uses existing stylesheets to render components ✔️

Functional Requirements

Functional Requirement yes/no
The Square component renders properly and executes the callback on a click event. ✔️
The Board component renders a collection of squares ✔️
The App component renders a board and uses state to maintain the status of the game. ✔️
Utilizes callbacks to UI events to update state ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 4+ in Code Review && 2+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-3 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

id={id}
value={value}
onClickCallback={onClickCallback}
player={player}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a big issue but I wanted to point out that player is being passed as a prop but isn't ever used by the Square component. Its good practice to remove any props that you end up not using (with the exception of key).
This is similar to the advice we'd give about arguments in functions.


// wave 3
const checkForWinner = (squares) => {
const winningRows = [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clever!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants