forked from AdaGold/react-tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 48
Time - Vera #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
veralizeth
wants to merge
16
commits into
Ada-C13:master
Choose a base branch
from
veralizeth:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Time - Vera #42
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1336fb0
UpdateValue funtion to handle the callback
veralizeth 4695118
generateSquareComponents function to create and array of squares
veralizeth 73073cc
onSquareClick to handle the square ID has been clicked
veralizeth 4326a6c
package-log
veralizeth 09597eb
Returning and 2D squareList, solving error
veralizeth 8e6f1d0
Cleannig the console.log prints
veralizeth d2670ca
Changing variable name for squareClikedId
veralizeth dddfba8
Ternary to know when it is turn of player1 or player2. Handle the pla…
veralizeth 25434d5
passing the id,value and onclick props, refactoring onSquareClick
veralizeth a395461
checkForWinner function select the winner X or O
veralizeth 439ee5a
refactoring checkForWinner, WINNINGOPTIONS as a constant
veralizeth 242b00d
Adding comments to the functions
veralizeth c2ba0ae
While the winner === nul that means the game is active, Return false …
veralizeth ccc613a
Display information of the winner player or the tie
veralizeth c7904c3
Adding some styling
veralizeth 1376247
Some comments
veralizeth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,12 @@ | ||
| div.grid { | ||
| width: 600px; | ||
| height: 600px; | ||
| margin: 0 auto; | ||
| background-color: #34495e; | ||
| margin: 30px auto; | ||
| background-color:lightcoral; | ||
| color: #fff; | ||
| border: 6px solid #2c3e50; | ||
| border: 6px solid lightcoral; | ||
| border-radius: 10px; | ||
| display: grid; | ||
| grid-template: repeat(3, 1fr) / repeat(3, 1fr); | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So concise!