Open
Conversation
Author
|
I never got wave 3 working, but I wanted to turn something in rather than get too far behind. |
React Tic Tac ToeMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
kaidamasaki
reviewed
May 5, 2020
kaidamasaki
left a comment
There was a problem hiding this comment.
Good job! Even though winner detection was broken everything else worked and your code was generally quite well organized. 😄
| ## Wave 3 | ||
|
|
||
| For wave 3, you will add the game logic to detect if a player has one or if there is a tie (all squares filled and with no winner). To do this you will complete the `checkForWinner` method and display the winner in the `header` section. The game should also cease responding to clicks on the board if the game has a winner. | ||
| For wave 3, you will add the game logic to detect if a player has won or if there is a tie (all squares filled and with no winner). To do this you will complete the `checkForWinner` method and display the winner in the `header` section. The game should also cease responding to clicks on the board if the game has a winner. |
There was a problem hiding this comment.
Yeah, that's legit. I'll go fix that.
Comment on lines
+76
to
+83
| for (let i = 0; i < possibleLines.length; i++) { | ||
| const [a, b, c] = possibleLines[i]; | ||
| if (squares[a] && squares[a] === squares[b] && squares[a] === squares[c]) { | ||
| return squares[a]; | ||
| // return setWinner(activePlayer); | ||
| } | ||
| } | ||
| return null; |
There was a problem hiding this comment.
It looks like you tried to get a little too clever here. A bit if/else if statement would have been fine. It's gross but starting with the brute force way is generally a good way to get something working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?CS Fundamentals Questions
setState-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.