Time - Jocelyn

feedback.md

@@ -1,8 +1,8 @@
 # Feedback Rubric
 
-- Student Being Reviewed:
-- Reviewer:
-- Classroom:
+- Student Being Reviewed: Jocelyn Wang
+- Reviewer: Yaz O'Shaughnessy
+- Classroom: Time
 
 ## Manual App Testing
 
@@ -17,7 +17,7 @@
       1. Practices best practices working with APIs. (The .env is not checked into git, and no API token was directly used in the Ruby code without ENV.)
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -26,7 +26,7 @@
       2. Practices error handling with APIs. (For all pieces of code that make an API call, it handles API requests that come back with errors/error status codes appropriately.)
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -35,7 +35,7 @@
       3. Implements inheritance and inheritance idioms. There is a Recipient class. User and Channel inherit from Recipient. In Recipient, there are appropriate methods defined that are used in both User and Channel. Some may be implemented. Some may be template methods.	
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -51,7 +51,7 @@
   </ul>
     </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -60,7 +60,7 @@
     5. Practices instance methods vs. class methods appropriately. (The methods to list all Channels or Users is a class method within those respective classes.)
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -70,7 +70,7 @@
       6. Practices best practices for testing. (The project has and uses VCR mocking when running tests, and can run offline.)
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -80,7 +80,7 @@
       7. Practices writing tests. (The User, Channel, and Workspace classes have unit tests.)	
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -90,7 +90,7 @@
       8. There are also tests for sending messages (the location of these tests may differ, but is likely in Recipient)	
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -100,7 +100,7 @@
       9. Practices git with at least 15 small commits and meaningful commit messages	
    </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 </table>
@@ -118,31 +118,31 @@
    <td>1. As a user of the CLI program, I can <strong>list</strong> users and channels with the commands <code>list users</code> and <code>list channels</code>
    </td>
    <td>
-      yes/no
+      yes
    </td>
 
   </tr>
   <tr>
    <td>2. As a user of the CLI program, I can <strong>select</strong> users and channels	with the commands <code>select user</code> and <code>select channel</code>
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
   <tr>
    <td>3. As a user of the CLI program, I can show the details of a selected user or channel	with the command <code>details</code>
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
   <tr>
    <td>4. As a user of the CLI program, when I input something inappropriately, the program runs without crashing. Example commands to try are <code>do_something</code>, or <code>select user</code> followed by <code>Mr. Fakename</code>
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 </table>

individual-reflection.md

@@ -9,48 +9,48 @@ Answer the following comprehension questions **within this file.** Write your an
 ### `GET` Request Review
 
 1. Describe a GET request that your project makes, and the high-level description of what it does
-    - Answer:
+    - Answer: One GET request the project makes is to request the info related to all members. The basic format of the request is set up on the recipient.rb file using the self.get_recipient method. This method can then be inherited by the Member and Channel classes. When used in Member class, it will subsitute in the url and query parameters required for getting slack members and then save the info down to an array. 
 1. What is the verb of this request?
-    - Answer:
+    - Answer: GET (query)
 1. What is the path (or the URL, or endpoint) of this request?
-    - Answer:
+    - Answer: 'https://slack.com/api/users.list'
 1. What are the query params (the additional data sent with the request, besides the verb and the path)?
-    - Answer: 
+    - Answer: Token
 1. What is the syntax used to make this request? (Copy and paste a code snippet here)
     - Answer:
       ```ruby
       # Copy and paste your answer below this comment
-
+        response = HTTParty.get(url, query: query_parameters)
       # Copy and paste your answer above this comment
       ```
 1. What does the program do if the response comes back with a status code of 200?
-    - Answer: 
+    - Answer: Request was a success and program will continue
 1. What does the program do if the response does not come back with a status code of 200?
-    - Answer: 
+    - Answer: Request was not a success and program will prompt the user to fix the issue
 
 ### `POST` Request Review
 
 If your project does not make a POST request, read through Wave 3 on the original Slack CLI, and research and answer questions 1, 2, 3, 4, 6, and 7.
 
 1. Describe a POST request that your project makes, and the high-level description of what it does
-    - Answer:
+    - Answer: One POST request the project makes is to send messages through the app. The basic format of the request is set up in the recipient.rb file using the send_message method. This method can then be inherited by the Member and Channel classes. When used in Member class, it will subsitute in the url and query parameters required sending messages. If no recipient has been select, the user will be notified that the message was not sent and the program will prompt the user for the next action. 
 1. What is the verb of this request?
-    - Answer:
+    - Answer: POST (command)
 1. What is the path (or the URL, or endpoint) of this request?
-    - Answer:
+    - Answer: 'https://slack.com/api/chat.postMessage'
 1. What are the query params (the additional data sent with the request, besides the verb and the path)?
-    - Answer: 
+    - Answer: Token, message to be sent, the id of the recipient
 1. What is the syntax used to make this request? (Copy and paste a code snippet here)
     - Answer:
       ```ruby
       # Copy and paste your answer below this comment
-
+        response = HTTParty.post(MESSAGE_URL,query: query_parameters)
       # Copy and paste your answer above this comment
       ```
 1. What does the program do if the response comes back with a status code of 200?
-    - Answer: 
+    - Answer: The program will notify the user that their message was successfully sent and then continue to run, prompting the user for their next action. 
 1. What does the program do if the response does not come back with a status code of 200?
-    - Answer: 
+    - Answer: The request was not successfully and the user will be notified that the message was not sent. The program will then continue to run and prompt the user for their next action.
 
 ## Request & Response Cycle
 
@@ -62,11 +62,11 @@ There are two actors:
 
 Based on the project requirements, when Grace enters "list channels,"
 1. What is the request being made in the program?
-    - Answer: 
+    - Answer: query (through get request)
 1. Who is the client?
-    - Answer: 
+    - Answer: Grace
 1. Who is the server?
-    - Answer: 
+    - Answer: Slack API
 
 ## Part 2: Optional Refactoring