quin - time

feedback.md

@@ -1,8 +1,8 @@
 # Feedback Rubric
 
-- Student Being Reviewed:
-- Reviewer:
-- Classroom:
+- Student Being Reviewed: Quin
+- Reviewer: Angela
+- Classroom: Time
 
 ## Manual App Testing
 
@@ -17,7 +17,7 @@
       1. Practices best practices working with APIs. (The .env is not checked into git, and no API token was directly used in the Ruby code without ENV.)
     </td>
     <td>
-      yes/no
+      "test_helper.rb" contains an API token on line 37, where the token is passed as a parameter to ".filter_sensitive_data". This means the token gets outputted inside all the cassettes as well. You can hide the API token by replacing it with a different substitution string when .filter_sensitive_data is called. More details on <a href="https://relishapp.com/vcr/vcr/v/3-0-1/docs/configuration/filter-sensitive-data">this syntax here</a>.
     </td>
   </tr>
 
@@ -26,7 +26,7 @@
       2. Practices error handling with APIs. (For all pieces of code that make an API call, it handles API requests that come back with errors/error status codes appropriately.)
    </td>
    <td>
-      yes/no
+      All pieces of code that make an API call are covered in the test files, but the classes themselves don't currently check for errors
    </td>
   </tr>
 
@@ -35,7 +35,7 @@
       3. Implements inheritance and inheritance idioms. There is a Recipient class. User and Channel inherit from Recipient. In Recipient, there are appropriate methods defined that are used in both User and Channel. Some may be implemented. Some may be template methods.	
    </td>
    <td>
-      yes/no
+      ✅ Nice job! parent class Recipient is particularly clean. I like that the placeholder methods have a concise #override comment, which made it really clear that they're implemented in children classes
    </td>
   </tr>
 
@@ -51,7 +51,7 @@
   </ul>
     </td>
    <td>
-      yes/no
+      ✅
    </td>
   </tr>
 
@@ -60,7 +60,7 @@
     5. Practices instance methods vs. class methods appropriately. (The methods to list all Channels or Users is a class method within those respective classes.)
    </td>
    <td>
-      yes/no
+      ✅
    </td>
   </tr>
 
@@ -70,7 +70,7 @@
       6. Practices best practices for testing. (The project has and uses VCR mocking when running tests, and can run offline.)
     </td>
     <td>
-      yes/no
+      ✅
     </td>
   </tr>
 
@@ -80,7 +80,7 @@
       7. Practices writing tests. (The User, Channel, and Workspace classes have unit tests.)	
     </td>
     <td>
-      yes/no
+      ✅
     </td>
   </tr>
 
@@ -90,7 +90,7 @@
       8. There are also tests for sending messages (the location of these tests may differ, but is likely in Recipient)	
     </td>
     <td>
-      yes/no
+      ✅
     </td>
   </tr>
 
@@ -100,7 +100,7 @@
       9. Practices git with at least 15 small commits and meaningful commit messages	
    </td>
     <td>
-      yes/no
+      ✅ <em>"This branch is 14 commits ahead of Ada-C13:master."</em> - really close, try to commit more!
     </td>
   </tr>
 </table>
@@ -118,31 +118,31 @@
    <td>1. As a user of the CLI program, I can <strong>list</strong> users and channels with the commands <code>list users</code> and <code>list channels</code>
    </td>
    <td>
-      yes/no
+      ✅
    </td>
 
   </tr>
   <tr>
    <td>2. As a user of the CLI program, I can <strong>select</strong> users and channels	with the commands <code>select user</code> and <code>select channel</code>
    </td>
    <td>
-      yes/no
+      ✅
    </td>
   </tr>
 
   <tr>
    <td>3. As a user of the CLI program, I can show the details of a selected user or channel	with the command <code>details</code>
    </td>
    <td>
-      yes/no
+      ✅
    </td>
   </tr>
 
   <tr>
    <td>4. As a user of the CLI program, when I input something inappropriately, the program runs without crashing. Example commands to try are <code>do_something</code>, or <code>select user</code> followed by <code>Mr. Fakename</code>
    </td>
    <td>
-      yes/no
+      ✅
    </td>
   </tr>
 </table>

individual-reflection.md

@@ -9,48 +9,52 @@ Answer the following comprehension questions **within this file.** Write your an
 ### `GET` Request Review
 
 1. Describe a GET request that your project makes, and the high-level description of what it does
-    - Answer:
+    - Answer: it gets information from my slack workspace server about the contents of it (users, channels, etc.)
 1. What is the verb of this request?
-    - Answer:
+    - Answer: GET
 1. What is the path (or the URL, or endpoint) of this request?
-    - Answer:
+    - Answer: https://slack.com/api/conversations.list
 1. What are the query params (the additional data sent with the request, besides the verb and the path)?
-    - Answer: 
+    - Answer: token, endpoint
 1. What is the syntax used to make this request? (Copy and paste a code snippet here)
     - Answer:
       ```ruby
-      # Copy and paste your answer below this comment
-
-      # Copy and paste your answer above this comment
+        query = {
+            token: ENV["SLACK_TOKEN"]
+            }
+            response = HTTParty.get(BASE_URL + "conversations.list", query: query)
       ```
 1. What does the program do if the response comes back with a status code of 200?
-    - Answer: 
+    - Answer: it give you back the data of what endpoint you were calling
 1. What does the program do if the response does not come back with a status code of 200?
-    - Answer: 
+    - Answer: it does not give back the information you asked for, for various reasons 
 
 ### `POST` Request Review
 
 If your project does not make a POST request, read through Wave 3 on the original Slack CLI, and research and answer questions 1, 2, 3, 4, 6, and 7.
 
 1. Describe a POST request that your project makes, and the high-level description of what it does
-    - Answer:
+    - Answer: post transfers data to wherever you want to end it to
 1. What is the verb of this request?
-    - Answer:
+    - Answer: POST
 1. What is the path (or the URL, or endpoint) of this request?
-    - Answer:
+    - Answer: https://slack.com/api/chat.postMessage
 1. What are the query params (the additional data sent with the request, besides the verb and the path)?
-    - Answer: 
+    - Answer: token, text, channel
 1. What is the syntax used to make this request? (Copy and paste a code snippet here)
     - Answer:
       ```ruby
-      # Copy and paste your answer below this comment
-
-      # Copy and paste your answer above this comment
+        query = {
+        token: ENV["SLACK_TOKEN"],
+        text: message, 
+        channel: @slack_id
+        }
+        response = HTTParty.post(BASE_URL + "chat.postMessage", query: query)
       ```
 1. What does the program do if the response comes back with a status code of 200?
-    - Answer: 
+    - Answer: it means it has successfully sent the data
 1. What does the program do if the response does not come back with a status code of 200?
-    - Answer: 
+    - Answer: it does not send the data because there is an error
 
 ## Request & Response Cycle
 
@@ -62,11 +66,11 @@ There are two actors:
 
 Based on the project requirements, when Grace enters "list channels,"
 1. What is the request being made in the program?
-    - Answer: 
+    - Answer: to list the channels of said workspace
 1. Who is the client?
-    - Answer: 
+    - Answer: the computer 
 1. Who is the server?
-    - Answer: 
+    - Answer: Slack API
 
 ## Part 2: Optional Refactoring
 
@@ -80,4 +84,4 @@ If your reflection inspired you to make minimal changes to your Slack CLI implem
 
 ### Describe your optional Slack CLI changes here
 
-Answer: 
+Answer: I added the table print functionality. I tried adding "real" error messages for invalid inputs, however I was afraid this would mess up all of my testing and put me over the 3 hour mark