Time - Vera #42
Open
Time - Vera #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most everything looks excellent, cleanly written, and I expect that it's fully functional. That said, tI was unable to verify the functional requirements due to the following error when I tried to run Slack.rb from the CLI: Traceback (most recent call last): 2: from slack.rb:3:in `<main>' 1: from /Users/Ruya/.rvm/rubies/ruby-2.6.5/lib/ruby/site_ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require' /Users/Ruya/.rvm/rubies/ruby-2.6.5/lib/ruby/site_ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- tty-prompt (LoadError).
|
Great work on this assignment, Vera! Your answers are great. Your answers are correct, accurate, and detailed. I love reading you talk about your code! :) Also, I'm so happy to hear about the improvements you made in handling the POST request failure. Your peer review feedback also looks good. In the future, with Ruby projects, we'll have more tools to help everyone (including your reviewers) download all of the gems with one command, so we won't see this problem again. Well done!! Great work!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry! I submitted that late. I thought I'd had submit it before.
The only adicional comment is, Alex wasn’t not able to run my code because I used a gem called.
gem 'tty-prompt', to allows me to create an Interactive CLI (Command Line Interface).