Time - Emily #44
Open
Time - Emily #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall, such good work!!! It also felt amazing to use because of the tty-prompt gem, and I'm so glad to know it exists so I can use it later on. I would definitely say that there aren't enough commits to represent the timeline of how this code came to be, so setting yourself up to make regular commits would be a major plus for me.
|
Great work on this assignment, Emily! Your answers look good and accurate and thoughtful, and your peer review feedback looks good too. It seems like there's an opportunity to refactor on the user experience of sending a message; good work on identifying that for a future you, one day (this is not an actual ask, I'm just happy to see the refactoring thoughts.). :D Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.