Time - Vicki

feedback.md

@@ -17,7 +17,7 @@
       1. Practices best practices working with APIs. (The .env is not checked into git, and no API token was directly used in the Ruby code without ENV.)
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -26,7 +26,7 @@
       2. Practices error handling with APIs. (For all pieces of code that make an API call, it handles API requests that come back with errors/error status codes appropriately.)
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -35,7 +35,7 @@
       3. Implements inheritance and inheritance idioms. There is a Recipient class. User and Channel inherit from Recipient. In Recipient, there are appropriate methods defined that are used in both User and Channel. Some may be implemented. Some may be template methods.	
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -51,7 +51,7 @@
   </ul>
     </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -60,7 +60,7 @@
     5. Practices instance methods vs. class methods appropriately. (The methods to list all Channels or Users is a class method within those respective classes.)
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
@@ -70,7 +70,7 @@
       6. Practices best practices for testing. (The project has and uses VCR mocking when running tests, and can run offline.)
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -80,7 +80,7 @@
       7. Practices writing tests. (The User, Channel, and Workspace classes have unit tests.)	
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -90,7 +90,7 @@
       8. There are also tests for sending messages (the location of these tests may differ, but is likely in Recipient)	
     </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 
@@ -100,7 +100,7 @@
       9. Practices git with at least 15 small commits and meaningful commit messages	
    </td>
     <td>
-      yes/no
+      yes
     </td>
   </tr>
 </table>
@@ -118,31 +118,31 @@
    <td>1. As a user of the CLI program, I can <strong>list</strong> users and channels with the commands <code>list users</code> and <code>list channels</code>
    </td>
    <td>
-      yes/no
+      yes
    </td>
 
   </tr>
   <tr>
    <td>2. As a user of the CLI program, I can <strong>select</strong> users and channels	with the commands <code>select user</code> and <code>select channel</code>
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
   <tr>
    <td>3. As a user of the CLI program, I can show the details of a selected user or channel	with the command <code>details</code>
    </td>
    <td>
-      yes/no
+      yes
    </td>
   </tr>
 
   <tr>
    <td>4. As a user of the CLI program, when I input something inappropriately, the program runs without crashing. Example commands to try are <code>do_something</code>, or <code>select user</code> followed by <code>Mr. Fakename</code>
    </td>
    <td>
-      yes/no
+      no, there isn't error handling for inputting an invalid user name or channel name.
    </td>
   </tr>
 </table>

individual-reflection.md

@@ -9,48 +9,59 @@ Answer the following comprehension questions **within this file.** Write your an
 ### `GET` Request Review
 
 1. Describe a GET request that your project makes, and the high-level description of what it does
-    - Answer:
-1. What is the verb of this request?
-    - Answer:
-1. What is the path (or the URL, or endpoint) of this request?
-    - Answer:
-1. What are the query params (the additional data sent with the request, besides the verb and the path)?
-    - Answer: 
-1. What is the syntax used to make this request? (Copy and paste a code snippet here)
+    - Answer: Based on token, the recipeint class with request the response data based on URL passed in. it will return the data if status of "ok" is true.
+2. What is the verb of this request?
+    - Answer: get
+3. What is the path (or the URL, or endpoint) of this request?
+    - Answer: depend on class called upon. if user then the url is "https://slack.com/api/users.list" 
+4. What are the query params (the additional data sent with the request, besides the verb and the path)?
+    - Answer: token
+5. What is the syntax used to make this request? (Copy and paste a code snippet here)
     - Answer:
       ```ruby
       # Copy and paste your answer below this comment
+        response = HTTParty.get(url,query:{token:TOKEN})
 
       # Copy and paste your answer above this comment
       ```
-1. What does the program do if the response comes back with a status code of 200?
-    - Answer: 
-1. What does the program do if the response does not come back with a status code of 200?
-    - Answer: 
+6. What does the program do if the response comes back with a status code of 200?
+    - Answer: return the response of data 
+7. What does the program do if the response does not come back with a status code of 200?
+    - Answer: a SlackAPIError will be raised
 
 ### `POST` Request Review
 
 If your project does not make a POST request, read through Wave 3 on the original Slack CLI, and research and answer questions 1, 2, 3, 4, 6, and 7.
 
 1. Describe a POST request that your project makes, and the high-level description of what it does
-    - Answer:
-1. What is the verb of this request?
-    - Answer:
-1. What is the path (or the URL, or endpoint) of this request?
-    - Answer:
-1. What are the query params (the additional data sent with the request, besides the verb and the path)?
-    - Answer: 
-1. What is the syntax used to make this request? (Copy and paste a code snippet here)
+    - Answer: when sending message. the recipient class will post the message to user or channel.
+2. What is the verb of this request?
+    - Answer: post
+3. What is the path (or the URL, or endpoint) of this request?
+    - Answer:URL = "https://slack.com/api/chat.postMessage"
+
+4. What are the query params (the additional data sent with the request, besides the verb and the path)?
+    - Answer: token, text (the message user entered), slack_id
+5. What is the syntax used to make this request? (Copy and paste a code snippet here)
     - Answer:
       ```ruby
       # Copy and paste your answer below this comment
-
+        resp = HTTParty.post(POST_URL, {
+                headers: {
+                "Content-Type": "application/x-www-form-urlencoded"
+                },
+                body: {
+                token: TOKEN,
+                channel: self.slack_id,
+                text: message
+                }
+            })
       # Copy and paste your answer above this comment
       ```
-1. What does the program do if the response comes back with a status code of 200?
-    - Answer: 
-1. What does the program do if the response does not come back with a status code of 200?
-    - Answer: 
+6. What does the program do if the response comes back with a status code of 200?
+    - Answer: the text will be posted on slack (user or channel)
+7. What does the program do if the response does not come back with a status code of 200?
+    - Answer: nothing (my code did not account for error on this part)
 
 ## Request & Response Cycle
 
@@ -62,11 +73,11 @@ There are two actors:
 
 Based on the project requirements, when Grace enters "list channels,"
 1. What is the request being made in the program?
-    - Answer: 
-1. Who is the client?
-    - Answer: 
-1. Who is the server?
-    - Answer: 
+    - Answer: workspace.channels is called 
+2. Who is the client?
+    - Answer: Grace
+3. Who is the server?
+    - Answer: Slack API
 
 ## Part 2: Optional Refactoring
 
@@ -80,4 +91,12 @@ If your reflection inspired you to make minimal changes to your Slack CLI implem
 
 ### Describe your optional Slack CLI changes here
 
-Answer: 
+Answer: added the following code in recipient class to account for API error when sending message. 
+
+    ```ruby
+    # Copy and paste your answer below this comment
+        if resp.parsed_response["ok"] == false || resp.code != 200
+            raise SlackAPIError, "Error on API #{resp["error"]}"
+        end 
+    # Copy and paste your answer above this comment
+    ```