Space - Katie #30
Open
Space - Katie #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 14, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Katie, well done. You hit the main learning goals here. Nice work. Take a look at my comments and let me know what questions you have.
Comment on lines
3
to
5
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def balanced(string) |
There was a problem hiding this comment.
👍 Space and time complexity?
I like the use of the hash here!
| @store[@front] = element | ||
| return element | ||
| elsif @front == (@rear + 1) % @size # queue full | ||
| puts("the qeue is full yo") |
| return element | ||
| elsif @front == (@rear + 1) % @size # queue full | ||
| puts("the qeue is full yo") | ||
| raise NotImplementedError |
There was a problem hiding this comment.
I suggest you raise a different error here.
| @rear = -1 | ||
| end | ||
|
|
||
| def enqueue(element) |
| qeue_front = self.front | ||
| if @front != @rear | ||
| @store[@front] = nil | ||
| @front += 1 |
There was a problem hiding this comment.
Suggested change
| @front += 1 | |
| @front = (@front + 1) % @store.length |
Comment on lines
36
to
38
| def front | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return @store[@front] | ||
| end |
There was a problem hiding this comment.
You should probably check to see if the Queue is empty
| return @store[@front] | ||
| end | ||
|
|
||
| def size |
There was a problem hiding this comment.
Why not use the positions of front and rear to calculate the size of the Queue.
| return count | ||
| end | ||
|
|
||
| def empty? |
There was a problem hiding this comment.
Again I suggest that you use front and rear to tell if the queue is empty.
| @@ -1,19 +1,19 @@ | |||
| class Stack | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation