-
Notifications
You must be signed in to change notification settings - Fork 47
Space - Stephanie #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Task ListMajor Learning Goals/Code Review
Functional Requirements/Manual Testing
| Successfully handles: Edit, Update | ✔️ Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
beccaelenzil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on your first rails project. You've implemented the MVC paradigm in rails! It looks like you overwrote the provided tests when you created the project. When I ran the tests, one had an error (no root_path), and one failed because you redirected somewhere else. These are minor issues, but in the future make sure you get the provided tests for key information on requirements. Keep up the hard work!
| @@ -0,0 +1,19 @@ | |||
| Rails.application.routes.draw do | |||
| # For details on the DSL available within this file, see https://guides.rubyonrails.org/routing.html | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a root path
| @@ -0,0 +1,12 @@ | |||
| <h2><%= @task[:name]%></h2> | |||
| <h4><%= @task[:description]%></h4> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using dot notation. @task.description
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions