Time - Jessica L

[jesshliang]

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe in your own words what the Model is doing in Rails	The Model defines the database of your application.
Describe in your own words what the Controller is doing in Rails	The controller is the mediator/coordinator between the user, events, and the display and the database.
Describe in your own words what the View is doing in Rails	The view is the display of what is returned from the database from events.
Describe an edge-case controller test you wrote	I wrote a test that checked if an invalid ID were passed into the application.
What is the purpose of using strong params? (i.e. the params method in the controller)	Strong params help control what ultimately gets passed in.
How are Rails migrations related to Rails models?	Migrations change the schema of the model.
Describe one area of Rails that are still unclear on	I could not write the final test for a patch request toggling my complete_task_path. However, I am not sure why it was failing.

[beccaelenzil]

Task List

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages	✔️
Routes follow RESTful conventions	✔️
Uses named routes (like _path)	✔️
Creates Models and migrations	✔️
Creates styled views	✔️
Handles errors like nonexistant tasks	✔️
Uses form_with to render forms in Rails	✔️

Functional Requirements/Manual Testing

Functional Requirement	yes/no
Successfully handles index & show	✔️
index & show tests pass	✔️
Successfully handles: New, Create	✔️
New, Create tests pass	✔️
Successfully handles: Edit, Update	✔️
Successfully handles: Destroy, Task Complete	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	5+ in Code Review && 5+ in Functional Requirements	✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

[beccaelenzil]

Great work on this project. It's stylin` and the user experience is superb. Furthermore, nice work fleshing out the tests for create, update, and destroy. It is clear that the learning goals for this were met. Keep up the hard work!

[beccaelenzil]

Consider how making two separate methods, for instance mark_complete and mark_incomplete would make this action idempotent.

[beccaelenzil]

Great work fleshing out the test for changes to the db. For a thorough destroy test you should also test what happens for an invalid task id.

[beccaelenzil]

Great work with the stylin'!

[beccaelenzil]

Consider using a ternary for this conditional view logic.