Skip to content

Conversation

@seaweeddol
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails Model is the database for the project. It holds the shape of the data (the schema), and all instances of the model.
Describe in your own words what the Controller is doing in Rails The controller holds all of the actions for the project. It tells Rails what to do when each route is accessed.
Describe in your own words what the View is doing in Rails The view is how Rails knows what to show the user for each route. This is where HTML and erb goes.
Describe an edge-case controller test you wrote I wrote a test to check if an invalid id is provided to the destroy action, it should not change any tasks and respond with a 404 not found error.
What is the purpose of using strong params? (i.e. the params method in the controller) The params are specific to the route that is currently being used. The params are the data that is received from the specific instance that can be used to send off to the model.
How are Rails migrations related to Rails models? Migrations are changes in the database schema (the structure of a model). A migration occurs each time the structure of a model is changed. It keeps track of how a model's schema changes over time and tells Active Record how the model should be structured.
Describe one area of Rails that are still unclear on I am not totally clear on how the routes and controller actions work together - particularly for the custom routing. My mark_complete action works but I don't exactly understand how it works. I tried changing @task.update in the mark_complete action to @task.mark_complete, but wasn't able to get where I wanted so I think I'm missing something there. I'm also unclear on all of the Rails magic and if I need to have any deeper understanding of what is happening in the background to make everything work.

@jmaddox19
Copy link

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages ✔️ So many commits with good messages!
Routes follow RESTful conventions ✔️
Uses named routes (like _path) ✔️
Creates Models and migrations ✔️
Creates styled views ✔️
Handles errors like nonexistant tasks ✔️
Uses form_with to render forms in Rails ✔️

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️
index & show tests pass ✔️
Successfully handles: New, Create ✔️
New, Create tests pass ✔️
Successfully handles: Edit, Update ✔️
Successfully handles: Destroy, Task Complete ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 5+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 4+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-2 in Code Review or 0-3 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Great work!

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants