Space - Hala #36
Open
Space - Hala #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
May 7, 2020
Comment on lines
+1
to
+5
| # TASKS = [ | ||
| # {task: "Clean the dishes"}, | ||
| # {task: "Take out the trash"}, | ||
| # {task: "Take the kids to the park"} | ||
| # ] |
There was a problem hiding this comment.
Suggested change
| # TASKS = [ | |
| # {task: "Clean the dishes"}, | |
| # {task: "Take out the trash"}, | |
| # {task: "Take the kids to the park"} | |
| # ] |
Can be deleted
| redirect_to task_path(@task.id) | ||
| return | ||
| else | ||
| render :new |
There was a problem hiding this comment.
Just a suggestion, include a status code:
Suggested change
| render :new | |
| render :new, status: :bad_request |
| redirect_to tasks_path | ||
| return | ||
| else | ||
| render :edit |
There was a problem hiding this comment.
Suggested change
| render :edit | |
| render :edit, status: :bad_request |
| if @task.update( | ||
| completed_at: Date.today.to_s | ||
| ) | ||
| redirect_to request.referrer |
| <%= javascript_pack_tag 'application', 'data-turbolinks-track': 'reload' %> | ||
| </head> | ||
|
|
||
| <body> |
There was a problem hiding this comment.
I suggest putting navigation links here like maybe a link to create a new task, and view all tasks.
| @@ -0,0 +1,15 @@ | |||
| <%= form_with model: @task, class: 'edit-task' do |f| %> | |||
There was a problem hiding this comment.
I know this isn't required for Task List, just noting that for future projects you can DRY up this form code with a partial view.
| <div class=""> | ||
| <% @tasks.each do |task| %> | ||
| <div class="dl-horizontal"> | ||
| <% css_class = (task.completed_at.nil? || task.completed_at.empty?) ? 'nostrike' : 'strike' %> |
| <h1><%= @task.name %></h1> | ||
| <p>: <%= @task.description %></p> | ||
| <p> <%= @task.completed_at %></p> | ||
| <%= link_to "Edit", edit_task_path(@task), class:"btn btn-info" %> |
There was a problem hiding this comment.
I suggest using the strikethrough styling here as well.
| end | ||
| end | ||
|
|
||
| def update_completed_task |
Task ListMajor Learning Goals/Code Review
Functional Requirements/Manual Testing
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
SummaryNicely done, you hit all the learning goals here. I like the styling you added here. Well done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions