Skip to content

Conversation

@yesentorres
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails Model is storing the data generated by my app.
Describe in your own words what the Controller is doing in Rails Controller is redirecting the app to run the appropriate methods / data whenever an HTTP request is recieved.
Describe in your own words what the View is doing in Rails View is generating html files for the app.
Describe an edge-case controller test you wrote Did not write any tests.
What is the purpose of using strong params? (i.e. the params method in the controller) They're used so we don't need to specify each field individually.
How are Rails migrations related to Rails models? They help to generate / update the database schema.
Describe one area of Rails that are still unclear on Unclear about the "magic" going on underneath the hood.

@yesentorres
Copy link
Author

To Instructor:
Hi! Since I made my PR this morning, I've gone and finished yesterday's lectures that I was behind on and made new commits to this project. I pushed them, not expecting them to be graded but just so I could have it on record. However, now I'm worried if that might of messed things up for y'all on the grading side....let me know if I need to do anything. Apologies if this caused any trouble.

@kaidamasaki
Copy link

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages ✔️
Routes follow RESTful conventions ✔️
Uses named routes (like _path) ✔️
Creates Models and migrations ✔️
Creates styled views No Styles.
Handles errors like nonexistant tasks ✔️
Uses form_with to render forms in Rails ✔️

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️
index & show tests pass ✔️
Successfully handles: New, Create ✔️
New, Create tests pass ✔️
Successfully handles: Edit, Update ✔️
Successfully handles: Destroy, Task Complete ✔️

Overall Feedback

| Overall Feedback | Criteria | yes/no | ✔️
| --- | --- | --- |
| Green (Meets/Exceeds Standards) | 5+ in Code Review && 5+ in Functional Requirements |
| Yellow (Approaches Standards) | 3+ in Code Review && 4+ in Functional Requirements, or the instructor judges that this project needs special attention |
| Red (Not at Standard) | 0-2 in Code Review or 0-3 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention |

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Copy link

@kaidamasaki kaidamasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants