Skip to content

Conversation

@mulhoo
Copy link

@mulhoo mulhoo commented May 5, 2020

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails the model is holding all the data for the app (linked to database), contains state, no knowledge of UI
Describe in your own words what the Controller is doing in Rails gets the HTTP requests, handles the data from the model, then sends it to the view to be turned to HTML
Describe in your own words what the View is doing in Rails turns the data to HTML for the page, display
Describe an edge-case controller test you wrote
What is the purpose of using strong params? (i.e. the params method in the controller) helps prevent errors
How are Rails migrations related to Rails models? they're important. Don't delete them!
Describe one area of Rails that are still unclear on more on forms!

@dHelmgren
Copy link

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages ✔️
Routes follow RESTful conventions ✔️
Uses named routes (like _path) ✔️
Creates Models and migrations ✔️
Creates styled views ✔️
Handles errors like nonexistant tasks ✔️
Uses form_with to render forms in Rails ✔️

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️
index & show tests pass ✔️
Successfully handles: New, Create ✔️
New, Create tests pass ✔️
Successfully handles: Edit, Update ✔️
Successfully handles: Destroy, Task Complete see comment

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 5+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 4+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-2 in Code Review or 0-3 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Descriptive/Readable
Logical/Organized


<section>
<h3><%= @task.description%></h3>
<p>Completed on: <%= @task.completed_at%></p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I mark a task complete? I don't see a link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants