Skip to content

Conversation

@stpatrickschild
Copy link

@stpatrickschild stpatrickschild commented May 12, 2020

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The Model adds AR to the DB. AR is what converts the spreadsheet table that lives in DB into code usable objects that we can use in our ruby code.
Describe in your own words what the Controller is doing in Rails Controller is the central manger of a rails application. It takes a request from a web server, pulls information from data models, and makes decisions. It hands information to the view for rendering the data back to the user. (in short, accepts input and converts it to commands for the model/view. )
Describe in your own words what the View is doing in Rails The view is what renders data into HTML, to show it to the end-user. The view gets called after the index method for tasks controller runs.
Describe an edge-case controller test you wrote The edge-case is for the update/edit/delete action and it's redirection to the root page when makebelieve was made.
What is the purpose of using strong params? (i.e. the params method in the controller) They provide a way to enable data that comes from our forms.
How are Rails migrations related to Rails models? Migrations are things we are adding over time as we build up or application. They are the steps that we use in order to build up the schema. Migrations add or remove tables, columns and rows in Models.
Describe one area of Rails that are still unclear on Rails is actually one of my favorite things we have learned thus far. Like most thigns I spent way too much time debugging the ERB since they are so sensitive with indentation (like <%= and <% = make so much different.) but as i use it more I hope I will be comfortable.

@stpatrickschild stpatrickschild changed the title Jared and I are working on this Time - Hannah T May 14, 2020
def update
@task = Task.find_by(id: params[:id])
if @task.nil?
redirect_to root_path

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not a big deal but your indentation is a little off here.

@task = Task.find_by(id: params[:id])

if @task.nil?
redirect_to root_path

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation here as well.

@jmaddox19
Copy link

Task List

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
At least 6 commits with meaningful commit messages No, but this is due to git issues experienced toward the end of completion
Routes follow RESTful conventions ✔️
Uses named routes (like _path) ✔️
Creates Models and migrations ✔️
Creates styled views ✔️
Handles errors like nonexistant tasks ✔️
Uses form_with to render forms in Rails ✔️

Functional Requirements/Manual Testing

Functional Requirement yes/no
Successfully handles index & show ✔️
index & show tests pass ✔️
Successfully handles: New, Create ✔️
New, Create tests pass ✔️
Successfully handles: Edit, Update ✔️
Successfully handles: Destroy, Task Complete ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 5+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 4+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-2 in Code Review or 0-3 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Additional Feedback

Great work! I love the fun message that displays when the user has completed all their tasks :)

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation There are a couple places where the indentation was a little off. I use a VSCode plugin called indent-rainbow to help me identify these places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants