-
Notifications
You must be signed in to change notification settings - Fork 47
Time - Hannah T #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Time - Hannah T #44
Conversation
| def update | ||
| @task = Task.find_by(id: params[:id]) | ||
| if @task.nil? | ||
| redirect_to root_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not a big deal but your indentation is a little off here.
| @task = Task.find_by(id: params[:id]) | ||
|
|
||
| if @task.nil? | ||
| redirect_to root_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation here as well.
Task ListMajor Learning Goals/Code Review
Functional Requirements/Manual Testing
Overall Feedback
Additional FeedbackGreat work! I love the fun message that displays when the user has completed all their tasks :) Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions