Time - Haben & Hannah - T #12
Conversation
beccaelenzil
left a comment
beccaelenzil
left a comment
There was a problem hiding this comment.
Great work on this project. Your code is clear, concise, and well written. You made great choices about custom model methods that helped keep your controllers concise and focused on the task at hand. Your code is well tested. Keep up the hard work!
| end | ||
| end | ||
|
|
||
| describe "check in" do |
There was a problem hiding this comment.
Just as in with checkout, you should check that the rental count does (or doesn't) differ as appropriate when you check in.
| validates :phone, presence: true | ||
| validates :registered_at, presence: true | ||
|
|
||
| def add_checked_out |
There was a problem hiding this comment.
Great custom model methods that help make your controller super straightforward.
| let (:shelley) { customers(:customer_1) } | ||
|
|
||
| describe "Validation" do | ||
| it "requires name, address, city, state, postal_code, phone, registered_at" do |
There was a problem hiding this comment.
Remember to include at least one test that's valid, and one that's not. The test that's not should show that it can not create the customer when each of the required fields is missing.
Video Store APIMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
2 participants
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.
Reflection
/customers&/videosendpoints? What does the time complexity depend on? Explain your reasoning.POST /rentals/check-inendpoint? What does the time complexity depend on? Explain your reasoning.