Time - Hannah J. and Alex #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add customer fields
Video Store APIMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
kaidamasaki
reviewed
Jun 8, 2020
kaidamasaki
left a comment
kaidamasaki
left a comment
There was a problem hiding this comment.
Great job! I left a few comments but honestly don't have too much to say, your solution was really solid. 😃
| class Customer < ApplicationRecord | ||
| has_many :rentals | ||
|
|
||
| validates :id, presence: true |
There was a problem hiding this comment.
Requiring id to be present means that you can't rely on auto-assignment of IDs and breaks db:seed.
This isn't something you'd catch without doing a rails db:reset or something though, just something to keep in mind in the future.
Comment on lines
+8
to
+11
| def update_check_out_dates | ||
| self.check_out_date = Date.today | ||
| self.due_date = Date.today + 7 | ||
| end |
There was a problem hiding this comment.
It's confusing that this method doesn't save but your other update methods do.
Suggested change
| def update_check_out_dates | |
| self.check_out_date = Date.today | |
| self.due_date = Date.today + 7 | |
| end | |
| def update_check_out_dates | |
| self.check_out_date = Date.today | |
| self.due_date = Date.today + 7 | |
| return self.save | |
| end |
Comment on lines
+6
to
+12
| if @video.nil? || @customer.nil? | ||
| render json: { | ||
| errors: ['Not Found'], | ||
| }, status: :not_found | ||
|
|
||
| return | ||
| end |
There was a problem hiding this comment.
Since you repeat this logic I'd probably move it into find_video_and_customer as well.
Comment on lines
+7
to
+19
| let(:customer) { | ||
| customers(:pengsoo) | ||
| } | ||
| let(:video) { | ||
| videos(:parasite) | ||
| } | ||
|
|
||
| let(:rental_data) { | ||
| { | ||
| customer_id: customer.id, | ||
| video_id: video.id | ||
| } | ||
| } |
| } | ||
|
|
||
| before do # important! | ||
| post check_out_path, params: rental_params |
There was a problem hiding this comment.
I would probably have directly created the Rental instead of posting but that's mostly a stylistic choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Video Store API
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.
Reflection
/customers&/videosendpoints? What does the time complexity depend on? Explain your reasoning.POST /rentals/check-inendpoint? What does the time complexity depend on? Explain your reasoning.