India - Water #28
Open
India - Water #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 7, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work India, you hit the learning goals here. Well done. My only comments here were on the missing space/time complexities.
Comment on lines
21
to
+23
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def add_first(value) | ||
| raise NotImplementedError | ||
| end | ||
| def add_first(value) |
Comment on lines
29
to
+31
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def search(value) | ||
| raise NotImplementedError | ||
| def search(value) |
Comment on lines
43
to
+45
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max | ||
| raise NotImplementedError | ||
| def find_max |
Comment on lines
65
to
+67
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def find_min | ||
| raise NotImplementedError | ||
| def find_min |
Comment on lines
89
to
+91
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_first | ||
| raise NotImplementedError | ||
| end | ||
| def get_first |
Comment on lines
96
to
+98
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def add_last(value) | ||
| raise NotImplementedError | ||
| def add_last(value) |
Comment on lines
114
to
+116
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def length | ||
| raise NotImplementedError | ||
| def length |
Comment on lines
131
to
+133
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_at_index(index) | ||
| raise NotImplementedError | ||
| def get_at_index(index) |
Comment on lines
149
to
+151
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def visit | ||
| raise NotImplementedError | ||
| def visit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.