Earth/Taylor #22
Open
Earth/Taylor #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 28, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Taylor, you hit the learning goals here. Well done.
Comment on lines
+3
to
5
| # Time Complexity: O(nlogn) | ||
| # Space Complexity: O(n) | ||
| def balanced(string) |
There was a problem hiding this comment.
Since you have to go through all the chars and you're not splitting at each stage, this is O(n) for time complexity.
Comment on lines
+10
to
+12
| if chars.include?(char) | ||
| stack.push(char) | ||
| else |
There was a problem hiding this comment.
Could you do this with a hash where the keys are the open brace and he values are the matching close brace? That might help you dry up those if-else statements.
Comment on lines
+26
to
28
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def evaluate_postfix(postfix_expression) |
| (@end + 1) % @size == @start | ||
| end | ||
|
|
||
| def enqueue(element) |
| end | ||
| end | ||
|
|
||
| def dequeue |
| @@ -1,31 +1,65 @@ | |||
| class Queue | |||
| @@ -1,22 +1,24 @@ | |||
| require_relative 'linked_list' | |||
|
|
|||
| class Stack | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation