forked from AdaGold/stacks-queues
-
Notifications
You must be signed in to change notification settings - Fork 41
Earth - Kal #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kashenafi
wants to merge
2
commits into
Ada-C14:master
Choose a base branch
from
kashenafi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Earth - Kal #31
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,72 @@ | ||
| class Queue | ||
| MAX_SIZE = 20 | ||
|
|
||
| def initialize | ||
| # @store = ... | ||
| raise NotImplementedError, "Not yet implemented" | ||
| @store = Array.new | ||
| @front = @back = -1 | ||
| end | ||
|
|
||
| def enqueue(element) | ||
| raise NotImplementedError, "Not yet implemented" | ||
| if (@front == 0 && @back == MAX_SIZE - 1) || (@back == (@front -1) % MAX_SIZE - 1) | ||
| raise Exception.new("Queue is full.") | ||
| elsif @store.empty? | ||
| @front = 0 | ||
| @back = 0 | ||
| elsif @back == (MAX_SIZE - 1) && @front != 0 | ||
| @back = 0 | ||
| else | ||
| @back += 1 | ||
| end | ||
|
|
||
| @store[@back] = element # in any non exception case, add element to queue | ||
| end | ||
|
|
||
| def dequeue | ||
| raise NotImplementedError, "Not yet implemented" | ||
| # raise StandardError.new if @front == @back | ||
|
|
||
| raise Exception.new("Queue is empty") if @store.empty? | ||
|
|
||
| num_to_dequeue = @store[@front] # save the num to dequeue | ||
| @store[@front] = nil # overwrite element to delete | ||
|
|
||
| if @front == @back # queue is now empty | ||
| @front = @back = -1 | ||
| elsif @front + 1 == MAX_SIZE | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a note that this could be updated similar to what I mentioned in |
||
| @front = 0 | ||
| else # otherwise, add to front | ||
| @front += 1 | ||
| end | ||
|
|
||
| return num_to_dequeue | ||
| end | ||
|
|
||
| def front | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return @store[@front] | ||
| end | ||
|
|
||
| def size | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return 0 if @front == -1 | ||
| return @front < @rear ? @rear - @front + 1 : MAX_SIZE - @front + @rear | ||
| end | ||
|
|
||
| def empty? | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return @front == @back | ||
| end | ||
|
|
||
| def to_s | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| return @store.to_s | ||
| list = Array.new | ||
|
|
||
| @store[@front...MAX_SIZE].each do |item| | ||
| list.push(item) if item | ||
| end | ||
|
|
||
| if @back < @front # the queue has wrapped around | ||
| @store[0..@back].each do |item| | ||
| list.push(item) if item | ||
| end | ||
| end | ||
|
|
||
| return list.to_s | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,25 @@ | ||
| class Stack | ||
| def initialize | ||
| # @store = ... | ||
| raise NotImplementedError, "Not yet implemented" | ||
| @store = LinkedList.new | ||
| end | ||
|
|
||
| def push(element) | ||
| raise NotImplementedError, "Not yet implemented" | ||
| @store.add_first(element) | ||
| end | ||
|
|
||
| def pop | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return nil if self.empty? | ||
|
|
||
| element = @store.remove_first | ||
|
|
||
| return element | ||
| end | ||
|
|
||
| def empty? | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return @store.empty? | ||
| end | ||
|
|
||
| def to_s | ||
| return @store.to_s | ||
| end | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also be written as: