Earth - Denise - Tree Practice #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 15, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Denise, you hit the learning goals here. I had some notes on space/time complexity. Otherwise awesome work.
Comment on lines
+19
to
+22
| # Time Complexity: log(n) | ||
| # Space Complexity: log(n) | ||
|
|
||
| def add_helper(key, value, current) |
There was a problem hiding this comment.
👍 The space/time complexity is right if the tree is balanced and O(n) if not.
Comment on lines
+52
to
54
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find(key) |
There was a problem hiding this comment.
👍 The time complexity is right if the tree is balanced and O(n) if not. The space complexity (due to the call stack) is the same as the time complexity.
Comment on lines
+73
to
+76
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def inorder(current = @root, values = []) |
Comment on lines
+87
to
+90
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def preorder_helper(current, values) |
Comment on lines
+107
to
+110
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def postorder_helper(current, values) |
Comment on lines
+126
to
+128
| # Time Complexity: o(n) | ||
| # Space Complexity: O(h), where h = height | ||
| def height(current = @root) |
There was a problem hiding this comment.
👍 Nice work on the space/time complexity!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.