Sumitra - scissors class #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 3, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Sumitra, you hit the learning goals here. Well done. I found a few things on space/time complexity. Otherwise well done.
Comment on lines
+16
to
18
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(log n) | ||
| def add(self, key, value = None): |
Comment on lines
+50
to
52
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) | ||
| def find(self, key): |
There was a problem hiding this comment.
👍 However the space complexity is O(log n) due to the recursive call stack.
Comment on lines
+70
to
72
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def inorder(self): |
Comment on lines
+94
to
96
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def preorder(self): |
Comment on lines
+118
to
120
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def postorder(self): |
Comment on lines
+142
to
144
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def height(self): |
There was a problem hiding this comment.
👍 However the space complexity is O(log n) for a balanced tree.
|
|
||
| return self.helper_bf(self.root, nodes_in_tree) | ||
|
|
||
| def helper_bf(self, node, nodes_in_tree): |
There was a problem hiding this comment.
Do you need the helper? You're not doing recursion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.