Skip to content

Breakout Room 16 - Implementing Mad Libs Generator #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anselrognlie wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −0
Open

Breakout Room 16 - Implementing Mad Libs Generator #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
Copy link
Copy Markdown
Collaborator

@linakl19 linakl19 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using "#" instead of "/" for writing comments. "/" are used in JavaScript, Python uses "#"

Copy link
Copy Markdown
Collaborator

@linakl19 linakl19 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//Loop back to this point once code finishes
# Loop back to this point once code finishes

loop = 1
while (loop < 9):
Copy link
Copy Markdown
Collaborator

@linakl19 linakl19 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A while loop works, however, when we have a fixed number of iterations it is better to use a for loop. In this case, a loop variable is not needed
for _ in range(10)

(https://www.geeksforgeeks.org/difference-between-for-loop-and-while-loop-in-python/)

// All the questions that the program asks the user
Copy link
Copy Markdown
Collaborator

@linakl19 linakl19 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// All the questions that the program asks the user
# All the questions that the program asks the user

noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
Copy link
Copy Markdown
Collaborator

@linakl19 linakl19 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, consider change "Name" for "Choose" as it is implemented on the other input messages.

adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
// Displays the story based on the users input
Copy link
Copy Markdown
Collaborator

@linakl19 linakl19 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Displays the story based on the users input
# Displays the story based on the users input

print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
Copy link
Copy Markdown
Collaborator

@linakl19 linakl19 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix variable name to "second_noun" instead of "seond_noun", otherwise, it is going to cause a NameError

print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Well it is.")
Comment on lines +13 to +20
Copy link
Copy Markdown
Collaborator

@linakl19 linakl19 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For readability, consider using f-strings or string interpolation
print (f"Be kind to your {plural_noun} in {place}")

print ("------------------------------------------")
// Loop back to "loop = 1"
Copy link
Copy Markdown
Collaborator

@linakl19 linakl19 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Loop back to "loop = 1"
# Loop back to "loop = 1"

loop = loop + 1