Skip to content

Malik Elmessiry C23 Snowman Feedback#29

Open
mikellewade wants to merge 1 commit intoAda-C23:mainfrom
malikelmessiry:main
Open

Malik Elmessiry C23 Snowman Feedback#29
mikellewade wants to merge 1 commit intoAda-C23:mainfrom
malikelmessiry:main

Conversation

@mikellewade
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Author

@mikellewade mikellewade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this project, Malik! Let me know if you have any questions about the comments that I left you!

wrong_guesses_list = []
wrong_guesses_count = 0

while wrong_guesses_count < SNOWMAN_MAX_WRONG_GUESSES:
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with this while loop! We don't actually know how many times it will take a user to guess the word or hit the limit of wrong guesses (could keep make invalid guesses) so this the perfect choice for that situation!


if is_word_guessed(snowman_word, correct_letter_guess_statuses):
print("Congratulations, you win!")
return
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of the return keyword. This allows for us to exit not only the while loop early if this condition is met but also the function as a whole.


guess = get_letter_from_user(correct_letter_guess_statuses, wrong_guesses_list)

if guess in snowman_word:
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way that this could be done is by checking the dictionary that was constructed with build_letter_status_dict. There are some advantages here that we've not talked about yet but it doesn't hurt to think through how it could be done!

correct_letter_guess_statuses[guess] = True
else:
wrong_guesses_list.append(guess)
wrong_guesses_count += 1
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we necessarily need to keep count of the wrong guesses? How could we get this same information from the list of wrong guesses that we have?

wrong_guesses_list.append(guess)
wrong_guesses_count += 1
print_snowman_graphic(wrong_guesses_count)
print(f"Wrong guesses so far: {wrong_guesses_list}")
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a better user experience, how could we alter this print statement so that the [] aren't wrapped around the guesses of a player?

@mikellewade mikellewade changed the title Malick Elmessiry C23 Snowman Feedback Malik Elmessiry C23 Snowman Feedback Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants