Conversation
add "return" after guessed the correct word
apradoada
left a comment
apradoada
left a comment
There was a problem hiding this comment.
Great job, Dehui!
Feel free to look through the feedback I have left here. Overall, the logic is sound, your tests pass and everything looks good! The suggestions I made are purely for adhering to coding conventions you will find in industry! None of them require updates unless you would like to update them.
Two other small general notes:
-
When it comes to commenting your code, we want to find a balance between too few comments and too many! While it is usually better to have more than you need rather than not enough, having a comment for every line starts to make things a little unreadable. It is usually a better idea to reserve comments for blocks of code as opposed to every single line!
-
I see there are just a few commits. This is a pretty basic project, so that makes sense. As we do more robust assignments, you will hear us say "commit early and often" during the program. In general, smaller and more commits can be helpful to see the full history of what you have done and go back and figure out where breaks happen! As we do larger projects, feel free to make more commits!
| if user_input in letter_statuses_dict: | ||
| letter_statuses_dict[user_input] = True | ||
| # check is_word_guessed, if yes, player wins, print message, exit; | ||
| if is_word_guessed(snowman_word, letter_statuses_dict): |
There was a problem hiding this comment.
While this isn't inherently too big of a deal, it can be a good idea to avoid nested conditionals if it isn't necessary. In this particular instance, checking if the word has been guessed correctly isn't dependent upon whether or not the guessed letter is in the word. If we moved this nested if statement to be a standalone conditional, the code will work the exact same way. In a situation like this where the location of the if statement does not change how the code works, it's generally a good idea to err on the side of un-nested conditionals!
| # check is_word_guessed, if yes, player wins, print message, exit; | ||
| if is_word_guessed(snowman_word, letter_statuses_dict): | ||
| print("Congratulations, you win!") | ||
| return |
There was a problem hiding this comment.
Using a return statement to end the loop as soon as a win condition is met is such a smart move! I am a huge advocate for ending a function early when it makes sense!
| print_snowman_graphic(len(wrong_guesses_list)) | ||
|
|
||
| # player loses, print message | ||
| print(f"Sorry, you lose! The word was {snowman_word}") |
There was a problem hiding this comment.
You've made a great choice here as well by recognizing that the win condition is handled in the loop so we don't have to worry with any conditionals outside of the loop! Great catch!
florasmile
left a comment
florasmile
left a comment
There was a problem hiding this comment.
Love all the comments. Accept all feedback from instructor Adrian and will make changes to the nested conditionals to the project and commit again.
2 participants
Welcome to your first Pull Request (PR), Dehui! In industry, when you want to merge any changes you have made to an existing codebase, a PR is used as a form of code review where a manager or peer can easily see the changes that have been made and review the new code that has been added! We will discuss them further in Unit 1, but they will be the primary method we use to give feedback on projects! Feel free to look through my comments and don't hesitate to reach out if you have any questions!