Conversation
apradoada
left a comment
apradoada
left a comment
There was a problem hiding this comment.
Great job, Allison!
Feel free to look through the feedback I have left here. Overall, everything looks good and the suggestions I made are purely for adhering to coding conventions you will find in industry! None of them require updates unless you would like to update them.
Two other small general notes:
When it comes to commenting your code, it can be a good idea to include comments for blocks of code to describe what they are doing. We do want to find a certain level of balance however. Right now you have comments before almost every line! While this can be helpful for your own learning, it can be a good idea to take some of them out in the final submission. My general rule of thumb is to use comments for blocks of code rather than every line.
I see there are a couple of commits. This is a pretty basic project, so that makes sense. As we do more robust assignments, you will hear us say "commit early and often" during the program. In general, smaller and more commits can be helpful to see the full history of what you have done and go back and figure out where errors happen! As we do larger projects, feel free to make more commits!
| correct_letter_guess_statuses = build_letter_status_dict(snowman_word) | ||
| wrong_guesses_list = [] |
There was a problem hiding this comment.
These variable declarations look good!
| user_input = get_letter_from_user(correct_letter_guess_statuses, wrong_guesses_list) | ||
| # Check if the user input is in the word | ||
| if user_input in correct_letter_guess_statuses: | ||
| print("This letter is in the word!") |
There was a problem hiding this comment.
Just a small thing, but when an incorrect letter is guessed, it tells you which letter was guessed. It might be a good idea to keep things consistent by doing the same thing if a correct letter is guessed!
| print("This letter is in the word!") | |
| print(f"The letter {user_input} is in the word!") |
| # Get a letter from the user | ||
| user_input = get_letter_from_user(correct_letter_guess_statuses, wrong_guesses_list) | ||
| # Check if the user input is in the word | ||
| if user_input in correct_letter_guess_statuses: |
There was a problem hiding this comment.
There is nothing inherently wrong with this particular conditional, but I do wonder what led you to check for the letter in correct_letter_guess_statuses rather than just the snowman_word. Technically they both have the same letters but if we follow the logic of the game, we'll want to check against the word itself rather than a dictionary that has been created by the word. This conditional closely mirrors a conditional in the function called on line 32 so comparing it to snowman_word directly avoids that duplication.
| if is_word_guessed(snowman_word, correct_letter_guess_statuses): | ||
| print("Congratulations, you win!") | ||
| return |
There was a problem hiding this comment.
Good call to check for the win condition within the loop and return the function early if the win condition is met! This is a very popular and widely used structure!
2 participants
Welcome to your first Pull Request (PR), Allison! In industry, when you want to merge any changes you have made to an existing codebase, a PR is used as a form of code review where a manager or peer can easily see the changes that have been made and review the new code that has been added! We will discuss them further in Unit 1, but they will be the primary method we use to give feedback on projects! Feel free to look through my comments and don't hesitate to reach out if you have any questions!