forked from AdaGold/react-chatlog
-
Notifications
You must be signed in to change notification settings - Fork 35
Crow24: Bcaprirolo Chatlog #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sausagehands
wants to merge
4
commits into
Ada-C24:main
Choose a base branch
from
sausagehands:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,37 @@ | ||
| import './App.css'; | ||
| import ChatLog from './components/ChatLog'; | ||
| import messages from './data/messages.json'; | ||
| import { useState } from 'react'; | ||
|
|
||
| const App = () => { | ||
| const [entries, setEntries] = useState(messages); | ||
|
|
||
| const toggleLike = (id) => { | ||
| setEntries(entries.map(entry => | ||
| entry.id === id | ||
| ? { ...entry, liked: !entry.liked } | ||
| : entry | ||
| )); | ||
| }; | ||
|
|
||
| const totalLikes = entries.filter(entry => entry.liked).length; | ||
|
|
||
| return ( | ||
| <div id="App"> | ||
| <header> | ||
| <h1>Application title</h1> | ||
| <section> | ||
| <h2>{totalLikes} ❤️s</h2> | ||
| </section> | ||
| </header> | ||
| <main> | ||
| {/* Wave 01: Render one ChatEntry component | ||
| Wave 02: Render ChatLog component */} | ||
| <ChatLog | ||
| entries={entries} | ||
| onLikeToggle={toggleLike} | ||
| /> | ||
| </main> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default App; | ||
| export default App; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,21 +1,32 @@ | ||||||||
| import PropTypes from 'prop-types'; | ||||||||
| import './ChatEntry.css'; | ||||||||
| import TimeStamp from './TimeStamp'; | ||||||||
|
|
||||||||
| const ChatEntry = () => { | ||||||||
| const ChatEntry = (props) => { | ||||||||
| return ( | ||||||||
| // Replace the outer tag name with a semantic element that fits our use case | ||||||||
| <replace-with-relevant-semantic-element className="chat-entry local"> | ||||||||
| <h2 className="entry-name">Replace with name of sender</h2> | ||||||||
| <article className="chat-entry local"> | ||||||||
| <h2 className="entry-name">{props.sender}</h2> | ||||||||
| <section className="entry-bubble"> | ||||||||
| <p>Replace with body of ChatEntry</p> | ||||||||
| <p className="entry-time">Replace with TimeStamp component</p> | ||||||||
| <button className="like">🤍</button> | ||||||||
| <p>{props.body}</p> | ||||||||
| <p className="entry-time"><TimeStamp time={props.timeStamp} /></p> | ||||||||
| <button | ||||||||
| className="like" | ||||||||
| onClick={() => props.onLikeToggle(props.id)} | ||||||||
|
||||||||
| onClick={() => props.onLikeToggle(props.id)} | |
| onClick={() => props.onLikeToggle(props.id)} | |
| aria-label={props.liked ? "unlike" : "like"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import PropTypes from 'prop-types'; | ||
| import ChatEntry from './ChatEntry'; | ||
|
|
||
| const ChatLog = (props) => { | ||
| return ( | ||
| <section> | ||
| {props.entries.map(message => ( | ||
| <ChatEntry | ||
| key={message.id} | ||
| id={message.id} | ||
| sender={message.sender} | ||
| body={message.body} | ||
| timeStamp={message.timeStamp} | ||
| liked={message.liked} | ||
| onLikeToggle={props.onLikeToggle} | ||
| /> | ||
| ))} | ||
| </section> | ||
| ); | ||
| }; | ||
|
|
||
| ChatLog.propTypes = { | ||
| entries: PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| id: PropTypes.oneOfType([PropTypes.number, PropTypes.string]).isRequired, | ||
| sender: PropTypes.string.isRequired, | ||
| body: PropTypes.string.isRequired, | ||
| timeStamp: PropTypes.string.isRequired, | ||
| liked: PropTypes.bool.isRequired, | ||
| }) | ||
| ).isRequired, | ||
| onLikeToggle: PropTypes.func.isRequired | ||
| }; | ||
|
|
||
| export default ChatLog; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All chat entries are hardcoded with the "local" class, which means all messages will appear on the left side with yellow styling. Based on the CSS file which defines both "local" and "remote" styles, the className should be dynamically determined based on which user sent the message. Consider adding logic to differentiate between local and remote messages, possibly by comparing the sender to a current user prop.