Snowman Feedback - Divya Potnuru

[yangashley]

No description provided.

[yangashley]

Nice job! Please review my comments, and let me know if you have any questions.

[yangashley]

Suggested change

	correct_letter_guess_statuses = build_letter_status_dict(snowman_word)
	correct_letter_guess_statuses = build_letter_status_dict(snowman_word)

Remove extra whitespace. Small inconsistencies in a codebase add up and they make the code more difficult to read/understand and harder to maintain (update/refactor).

Code that is ready for review, like what is here in this PR, should comply with style conventions as described by the official Python style guide.

You can read more about whitespaces here.

[yangashley]

Suggested change

	while len(wrong_guesses_list) < SNOWMAN_MAX_WRONG_GUESSES :
	while len(wrong_guesses_list) < SNOWMAN_MAX_WRONG_GUESSES:

Remove 2 extra whitespaces to keep your code neat and professional.

[yangashley]

Suggested change

Unnecessary blank line should be removed.

Avoid adding unnecessary blank lines to your project because it makes your codebase longer and doesn't comply with the PEP8 style guide.

The guide says "Surround top-level function and class definitions with two blank lines." and "Extra blank lines may be used (sparingly) to separate groups of related functions."

Review the style guide recommendations on blank lines here.

[yangashley]

👍 Nice job using finding the length of wrong_guesses_list and passing that value to print_snowman_graphic. Doing so means you don't need to create an unnecessary variable like wrong_guesses_count that would need to be manually incremented (which would be a place that a bug could get introduced).

[yangashley]

A return statement in Python stops the execution of code, which is why I suspect you return None here. I'm wondering if you can think of another way the logic could be written so that you can end the game without needing to return None to break the loop?

This isn't a requirement, but if you'd like more practice with writing conditional logic in Python, I'd suggest thinking through and re-writing the logic so you don't need return to stop the game.

If you choose to do so, there's no need for you to submit anything to me for re-review. This would just be for your own practice 😊

[yangashley]

Different development teams will have different guidelines, but we typically want to describe the contents of a variable and can leave off the data type in the name. This is especially true in languages other than Python that require folks to declare a variable's type when we create it.

It would be completely valid and in some cases preferable to call this variable wrong_guesses rather than wrong_guesses_list.

[yangashley]

Suggested change

	correct_letter_guess_statuses [user_input] =True
	correct_letter_guess_statuses[user_input] = True

There is an extra white space before [. When you set a key/value pair in a dictionary it should look like dict[key] = value` with no extra or missing whitespaces.

There is a missing whitespace after =.

Take care to look over your own code before you submit it for review, especially when you're at internship. Small inconsistencies in a large codebase are like a death by 1000 paper cuts. Each inconsistency makes the codebase more difficult to maintain.

[yangashley]

Here you do not use a blank line before the else block, which aligns with style guidelines (unlike the blank line on line 33).

# correct style for writing if/else without extra blank lines
if some_condition:
    # do something
else:
    # do something else