Open
Conversation
yangashley
reviewed
Nov 14, 2025
| @@ -1 +1,64 @@ | |||
| from flask import Blueprint No newline at end of file | |||
| from flask import Blueprint, abort, make_response, request, Response | |||
| @@ -0,0 +1,66 @@ | |||
| from flask import abort, make_response, Response, request | |||
There was a problem hiding this comment.
Remove unused imports
Suggested change
| from flask import abort, make_response, Response, request | |
| from flask import abort, make_response, request |
| @@ -1 +1,68 @@ | |||
| from flask import Blueprint No newline at end of file | |||
| from flask import Blueprint, abort, make_response, request, Response | |||
There was a problem hiding this comment.
abort, make_response are imported but not accessed so they should be removed
Suggested change
| from flask import Blueprint, abort, make_response, request, Response | |
| from flask import Blueprint, request, Response |
| class Goal(db.Model): | ||
| id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) | ||
| title: Mapped[str] | ||
| tasks: Mapped[list["Task"]] = relationship(back_populates="goal") |
Comment on lines
+28
to
+29
| new_goal = cls(title = goal_data["title"]) | ||
| return new_goal |
There was a problem hiding this comment.
You could directly return the object since you create the variable new_goal and then immediately return it without accessing it.
Suggested change
| new_goal = cls(title = goal_data["title"]) | |
| return new_goal | |
| return cls(title = goal_data["title"]) |
| return new_model.to_dict(), 201 | ||
|
|
||
| def generate_slack_notification(model_attribute): | ||
| path = "https://slack.com/api/chat.postMessage" |
There was a problem hiding this comment.
constant variables should be named with all caps
Suggested change
| path = "https://slack.com/api/chat.postMessage" | |
| PATH = "https://slack.com/api/chat.postMessage" |
Comment on lines
+61
to
+62
| json = { | ||
| "channel": "task-notifications", |
There was a problem hiding this comment.
The channel name appears here as a magic string should be avoided by using a constant variable instead.
Suggested change
| json = { | |
| "channel": "task-notifications", | |
| CHANNEL_NAME = "task-notifications" | |
| json = { | |
| "channel": CHANNEL_NAME, |
| "text": f"Someone just completed the task {model_attribute}" | ||
| } | ||
|
|
||
| slack_response = requests.post(path, headers=headers, json=json) No newline at end of file |
There was a problem hiding this comment.
You create the variable slack_response bud don't return it from the funciton.
Do you need this value and mean to return it or do we not need to return anything at all?
Suggested change
| slack_response = requests.post(path, headers=headers, json=json) | |
| requests.post(path, headers=headers, json=json) |
| from .routes.task_routes import bp as task_bp | ||
| from .routes.goal_routes import bp as goal_bp | ||
| from .db import db, migrate | ||
| from .models import task, goal |
There was a problem hiding this comment.
Your assertions for the tests in wave 1 look good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.