Skip to content

Completed primary requirements #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Dreedle wants to merge 30 commits into
base: ald/master
Choose a base branch
from
Open

Completed primary requirements #40

Dreedle wants to merge 30 commits into from

Conversation

@Dreedle
Copy link

@Dreedle Dreedle commented Oct 23, 2015

Chose to make default csv for the methods the csvs supplied with the assignment, so as to allow for different csvs to be passed in.
Created additional truncated csvs for the sake of shortening rspec run time, and used those in many of the rspecs.

Dreedle added 30 commits October 19, 2015 16:34
@Dreedle
Added attr_readers and methods
bd1e866
@Dreedle
Fixed vendor bug that had been in baseline. Rspecs run now
978e457
@Dreedle
self.all method for Market.rb passes specs
714d2ae
@Dreedle
Market.all method was not working, is working now
306bfda
@Dreedle
Market.find(id) method passes specs
e74caf9
@Dreedle
Market methods take default csv
7a63723
@Dreedle
Vendor.all and Vendor.find pass specs
41d3dc7
@Dreedle
Product.all and Product.find passing specs
fe063d4
@Dreedle
Sale.all and Sale.find passing specs
4ea854d
@Dreedle
Trying to implement @market.vendors, not finished
1837997
@Dreedle
#market.vendors method passes specs
e36bf00
@Dreedle
Improved test for market.vendors
2bfc5d8
@Dreedle
vendor.market method passing specs
a4130fb
@Dreedle
Corrected market.vendors to take any csv
8a3fc2e
@Dreedle
Improved market_spec for market.vendors
3f974a2
@Dreedle
improved vendor.market
fd9ba6e
@Dreedle
vendor.products is passing specs
2fe3124
@Dreedle
vendor.sales method passing specs
a1c83ea
@Dreedle
Used .send in Vendor
5b37a87
@Dreedle
Added vendor spec for by_market
9e24036
@Dreedle
Product.by_vendor passing specs
8d162a3
@Dreedle
Product.sales passing specs
16d5621
@Dreedle
Repaired sale_spec for non-default find
8d1e7f9
@Dreedle
sale.product and sale.vendor pass specs
5c94f5c
@Dreedle
vendor.revenue is passing specs
5090ca0
@Dreedle
product.number_of_sales passing specs
ad7b278
@Dreedle
Sale.between is passing specs
5e366ec
@Dreedle
removed superfluous comments
b797dfb
@Dreedle
Completed primary requirements
50177af
@Dreedle
Removing binding.pry from tests
44b566a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dreedle