Kld/master #41
Open
Kld/master #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds, fixed hash in product
…d_vendors method to be an instance method, not a class method
…unt method for sale class
…ed Market class to use the new Vendor hash-creator method too
…ted Vendor class to use this method as well
…ted all other class files to use it
…e to open the CSV file
…e to open the CSV file, and changed find_vendors method for Market as a result
…le to open the CSV file, and changed find_products method for Vendor as a result
…to open the CSV file, and changed find_sales method for Product as a result, also fixed bug in Vendor find_products method
… rspec now < 1 sec when it was 5+ before all this CSV refactoring
… classes to instance variables
…a little victory dance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.