Skip to content

FarMar w/optional requirements I and II #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jbuechs wants to merge 107 commits into
base: jlb/master
Choose a base branch
from
Open

FarMar w/optional requirements I and II #45

jbuechs wants to merge 107 commits into from

Conversation

@jbuechs
Copy link

@jbuechs jbuechs commented Oct 23, 2015

Finished most methods for requirements I and II
Learned about include and extend for modules

jbuechs added 30 commits October 19, 2015 15:40
@jbuechs
create test for Market.all
8187624
@jbuechs
complete market.all method
96aca23
@jbuechs
update market initialize test
905ce1b
@jbuechs
create init tests for product class
7501c43
@jbuechs
create product initialize method
0b1d39f
@jbuechs
create product all method
0257c58
@jbuechs
refactor to include farmar base class
26d719f
@jbuechs
refactor init methods to use base class
3b90a36
@jbuechs
create sale tests
7d2ec0a
@jbuechs
complete sale init and all methods
c3c9aac
@jbuechs
create vendor initialize test
26c7733
@jbuechs
create vendor initialize and convert_to_hash methods
c3e1f21
@jbuechs
create test for vendor all method
811c56f
@jbuechs
create vendor all method
d7c0791
@jbuechs
refactor self method to use filename constant
19a397e
@jbuechs
create tests for market find method
e7c5234
@jbuechs
complete beginning of market match method
91d6330
@jbuechs
create find method for market class
ae15ff7
@jbuechs
refactor find method to be in FarMar_Base class
45e2048
@jbuechs
delete redundant code in far_mar_base find method
82b1f4f
@jbuechs
create find test for product class
7693522
@jbuechs
create find test for sale spec
9259966
@jbuechs
create test for vendor find method
8f381d9
@jbuechs
create test for vendors method of Market class
350c3b7
@jbuechs
bugfix syntax issues in vendor method test
6574074
@jbuechs
create vendor method
b2c706e
@jbuechs
create vendor self.by_market method
70fd21b
@jbuechs
refactor market vendors method
cc59e46
@jbuechs
create tests for product.by_vendor
ae1fac7
@jbuechs
create product.by_vendor method
b0d9433
jbuechs added 30 commits October 22, 2015 14:02
@jbuechs
refactor Vendor.revenue method
617e226
@jbuechs
refactor vendor.most_revenue
89c524f
@jbuechs
refactor vendor.most_revenue method
f4bc0cc
@jbuechs
create test for most_items method
c31914f
@jbuechs
create vendor.most_items method
b6b9433
@jbuechs
refactor vendor most methods to use helper method
09d17cc
@jbuechs
create tests for vendor.day_revenue
56da2b2
@jbuechs
create vendor.day_revenue method
8786e42
@jbuechs
create test for product.revenue
dc56cf2
@jbuechs
create revenue method for product class
1a30341
@jbuechs
refactor revenue method into vendor product base class
7eba918
@jbuechs
refactor most_x method to be in vend_prod_base class
05a6bdf
@jbuechs
create tests for vendor.revenue(date)
ad35326
@jbuechs
create self.revenue_on(date) in vendor class
d17b2b1
@jbuechs
create test for most_revenue(n) method
dc0b03d
@jbuechs
refactor VendorProductBase to be a module instead of class
177afd6
@jbuechs
bugfix in most_revenue test
65eee10
@jbuechs
refactor to use methods from VendorProductBase module
49825b1
@jbuechs
refactor vendor class to use methods from VendorProductBase module
207079c
@jbuechs
add comments to better understand all the refactoring
6e68f8d
@jbuechs
randomize running of rspec tests
79ad1aa
@jbuechs
create beginnings of test for preferred and worst vendor
a8762fe
@jbuechs
refactor market.prefered_vendor to have nil default date
39f5d0a
@jbuechs
refactor worst_vendor method to have date as nil default
4355c9b
@jbuechs
create test for market.search method
d697e4a
@jbuechs
create FarMar::Market.search method
9de52ad
@jbuechs
create vendor.find_by_name(match) tests
1d9f047
@jbuechs
create vendor find_by_name
c234fdc
@jbuechs
refactor find_by_name to be in far_mar_base file
5aa03f6
@jbuechs
minor edits of comments and code
c02741f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jbuechs