FarMar project #42
Open
FarMar project #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in each. Finished methods and tests for market. Started methods for vendors and the corresponding tests.
…d. Market_spec updated to use let. vendor.rb added method to find product by vendor_id. vendor_spec added a test to make sure we were receiving array of the instances returned
…vendor. Added a test to check that vendor_spec sales method is running correctly. Added the sales method to vendor.rb
…d revenue method; started on numberof sale method. Sale.rb-Added methods to talk to product.rb. Vendor.rb-Added comments for clarity. Product_spec.rb-Added tests for sales method and revenue method; started number_of_sales method tests. Vendor_spec.rb-added let functions.
…g in market_spec. Added enumerable in sale.rb
…he first thing ran and then they were used in different places
… updated the self.all method and didn't push any of the values into an array, as I used map and the values were returned as an array already.
…r than each because each goes through every object, detect finds the first instance since there is only one. This sped up the run time
…his made it so I didn't have to push it into an array as it comes out as an array already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a solo project. I really enjoyed putting a lot of enumerables in and researched those. I also felt like I was understanding tests a lot more.