FarMar FarMore FarMer Ben #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
March 14, 2016 12:50
…Self.all creates a an instance for each row in the called csv. Added a test for .all method to all specs. Everything passes, 100% coverage.
… spec for .fidmetethod. everything passes/methods work as expected.
…iple lines is commented out lines 39-48.
…ale.rb to_i.. dumbbbbb. fixed it.
…e method. it works
…o see if number_of_sales works.
…sting and used lets. also added a test for number_of_sales method for product.rb
… stupid ruby takes in the info as an integer and converts it to a string before I can do anything about it..
…e date time stuff. it works
…o use find_all and trying to shovel the arrays.. then realized I could just add 2 arrays together instead of getting subarrays within arrays. test works
…hhhhhh failing. still trying
… it works and the test works
…o me.. sooo. all tests work. still working on preferred_vendor(date)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made instance specific tests.. so please don't change the find(id) numbers. Finished the first set of optionals, the code works but it needs to be refactored (very repetitive).