FarMar! - Deirdre #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…through csv and only creating relevent instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require 'csv'
require 'chronic'
Phew! I'm really glad we spent the week doing this, even if it wasn't as fun as making a game where a t-rex gets closer to eating people in a car as a user scrambles to guess letters. But this project solidified some topics that I needed practice with, and gave me a chance to struggle through some things I hadn't tried before.
I refactored my entire project after day two to scan through csv files instead of always creating instances, which could have been an alright decision, but man did it bite me on the sales methods. Now my stinking tests take forever. But I got a ton of practice working with CSV files so it's alright.
I tried many optionals, from part one I worked mainly on Market methods, and managed to get the vendor method for most_revenue as well. Once I had tried a few of those I checked out options part 2 and was finally able to get all and self methods extracted into a class that lives in far_mar.rb.