forked from AdaGold/FarMar
-
Notifications
You must be signed in to change notification settings - Fork 26
FarMar #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
meliquintero
wants to merge
30
commits into
Ada-C5:master
Choose a base branch
from
meliquintero:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FarMar #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame tests) (copy and paste carnival))
…tion of FarMar::Vendor instances that are associated with the market by the market_id field
…et instance that is associated with this vendor using the FarMar::Vendor market_id field
…um of all of the vendor's sales (in cents)
…urns all of the vendors with the given market_id. Created tests for it. Refactored some methods here and there
…urns all of the vendors with the given market_id. FOR REAL
… of FarMar::Sale instances that are associated using the FarMar::Sale product_id field. tested it too
…ass, and its tests
…sociated with this sale using the FarMar::Sale vendor_id field. Tests done too
…s the FarMar::Product instance that is associated with this sale using the FarMar::Sale product_id field
…urns the number of times this product has been sold
…arrays resoult of the enumerables
…) method that returns a collection of FarMar::Sale objects where the purchase time is between the two times given as arguments.
…lection of FarMar::Product instances that are associated to the market through the FarMar::Vendor class. Refactored here and there.
…or the given date
…f.searchsearch_term. Finished ann tested
…ste lat method, and change the max_by for a min_by
…ns the top n vendor instances ranked by total revenue
…n) returns the top n vendor instances ranked by total number of items sold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally!!