Val's Task Tracker! #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make the columns work the right way
…ld be more specific with my styling.
…at I did. I'm about to start working on the Edit button.
… add page. Need to figure out how to make this update route work.
…cause it's the verb that determines what to do with a route too
…ng name attribute to DONE button, which allows the update method to use the right params depending on if it was the DONE button or edit button
…and editing tasks now
…ask model, and made it so layout only shows DONE button if the task is still incomplete
…the link between them
| <li><%= link_to "Edit", edit_task_path(task.id) %></li> | ||
| <li> | ||
| <%= link_to "Delete", task_path(task.id), method: :delete, | ||
| data: { confirm: 'Are you sure you want to delete this task?' } %> |
There was a problem hiding this comment.
Nice use of confirm to have user verify delete action! 🚀
|
Nice work! I love how consistent you are with indentations and spacing. It makes it really easy to read your code. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here ya go!
It definitely does not have as nice of a user experience as I would like, but alas, this is what I've got in time for the PR deadline. At least it works!