Skip to content

Done #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
abrown152 wants to merge 69 commits into
base: master
Choose a base branch
from
Open

Done #4

abrown152 wants to merge 69 commits into from

Conversation

@abrown152
Copy link

@abrown152 abrown152 commented Jun 24, 2016

Leah and Alysia

leahnp and others added 30 commits June 14, 2016 14:37
@leahnp
added js files for rentals, customers, movies routes
32b38bd
@leahnp
create index route to server it works json data
c58a53f
@leahnp
added empty controllers
1e79dd1
@leahnp
added db dirs and files
1146f58
@leahnp
added controller scaffolding
05a8c0f
@leahnp
added routes to costumes and placeholder methods
2fed9bb
@leahnp
added routes to movies and placeholder methods
923bffa
@leahnp
completed routes and controller setup
60a395b
@leahnp
added scripts to package.json
ffb9db4
@leahnp
create schema
7210590
@leahnp
added vars to app js for db
609ea09
@leahnp
create db and loaded schema
017f585
@leahnp
added seed js file to auto seed from our json data
ac1de03
@leahnp
deleted other file where we were trying to seed json data
1830723
@leahnp
seed success! seed js file working
1a9d7ad
@leahnp
no changes
f62cec9
@abrown152
Added Customer.all model method.
5017a8d
@abrown152
Added Customer.all model and controller methods. Cleaned up funky code.
2c1687c
@abrown152
Added getMovie model and controller methods.
94e3dd3
@abrown152
Structured the getRentals function and associated functions.
0cb8c70
@abrown152
EOD commit.
7475951
@leahnp
implemented customer sort
66d9160
@leahnp
added sort movie functions
7272d8c
@leahnp
added rentals seed data
778a4b2
@leahnp
added function to return currently checked out videos for givien cust…
04a70b1 
…omer id
@leahnp
added get rental history for given id
b245782
@leahnp
working on returning data from movie and rentals models to get inventory
481795d
@leahnp
added instanbul
8f2444c
@leahnp
changed schema to include returned date
39b10c7
@leahnp
added getpastchecked out method that returns past rentals and sorts b…
dec1418 
…y returned date
leahnp and others added 28 commits June 21, 2016 21:50
@leahnp
got rentals/:title returning title, overview, release date, total inv…
101632c 
…entory and available copies
@leahnp
cleaned up commented out code and whitespace
25c8086
@leahnp
trying to setup test env everything is broken
35e9995
@leahnp
got test env config, can run npm run reset-test to create, schema, se…
59b985e 
…ed test db to use for testing, then npm start-test and npm run test
@leahnp
changed dev db to be named _development
c180749
@abrown152
Added basic customer controller tests.
f55f4d0
@leahnp
changed run test command, added tests to movies and rentals controllers
8983dfe
@leahnp
added test for customer model all method
971e971
@leahnp
added test for customer sort model method
17f324b
@leahnp
ignore coverage/ directory
c1f3358
@leahnp
switched views to render ejs, added docs ejs, route and controller
106260f
@leahnp
added json file, trying to find the best way to print it out in a view
4c2b109
@leahnp
changed rentals model error handling to be error or no results
7199638
@leahnp
changed errors for no data found in db
dadc847
@leahnp
changed error handling in customers controller to specify 500 or404
383ddd9
@leahnp
finished the rest of the error handling from the rentals model
d838d4b
@leahnp
finished the json docs for customers endpoint
d6d240a
@leahnp
updated error handling for movies model when no data is found
367f88c
@leahnp
updated routes to handle for both no data and error 500
2a6cc03
@leahnp
finished docs for /movies endpoint
60d6347
@leahnp
added html formatting for docs view to iterate through json file and …
965f029 
…print ul for each endpoint
@leahnp
cleaned up commented out code and whitespace
62da41f
@leahnp
put .json route above view route to give higher priority
148c82d
@leahnp
fixed incorrect variable names and made = ==
43b6264
@leahnp
added two tests to movies model spec, checking valid and invalid movi…
af2d109 
…e titles
@abrown152
Controller tests finished.
955dace
@abrown152
Added model tests.
4da180d
@abrown152
Finally got 90% test coverage. PR commit and byeeeeee
b2fc6f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lacuchilla lacuchilla

@kdefliese kdefliese

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abrown152 @lacuchilla @kdefliese @leahnp