Lumbersexuals - completed betsy (Hipsterly) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checking merge
| def index | ||
| @sellers = show_sellers | ||
| @categories = show_category | ||
| @category = params[:category] |
|
Awesome job on this project!! |
| (@order_items_paid << item) if item.order.status == "paid" | ||
| (@order_items_complete << item) if item.order.status == "complete" | ||
| end | ||
| #NEEDS ADDITIONAL CLAUSES TO IDENTIFY ORDER FROM ORDER ITEMS |
There was a problem hiding this comment.
Is this comment a TODO/note to self? It's a little confusing. If its about logic you'd like to add in the future, make sure to put that in your read me, but take it out here. When I see something like 'needs' in a comment - my first thought is - "is the developer trying to warn me about a datatype or argument I need to implement the code properly, and if so then why isn't that just evident in the readability about the code?"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So enjoyed working on this project with this fantastic team!-from Suze
Adriana, Nicole, Ania, Suzanne
Hipsterly:
https://hipsterly.herokuapp.com/