Lisa's Tunes & Takeout #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Tunes and Takeout API
…ere's an authenticated user logged in
…either find or create a new instance of user based on the credentials from the spotify login
…list of suggestions. path to the suggestions#index route
…hat wasn't capturing the query term in the params hash after searching
….escape() when passing each uri to the Yelp business API
…rdless of whether they have an image associated with their spotify account
…fter going to a page requiring you to be signed in
…k instead of just the image being a link
… return an Array of Food objects)
…nd the Array contains Music objects
… TunesTakeoutWrapper
…gn up from the same page
…te. changed panel titles to suggestion #
| redirect_to root_path | ||
| else | ||
| redirect_to root_path | ||
| end |
There was a problem hiding this comment.
To DRY your code better, you could use "redirect_to root_path" only once! and be a better-lazy-programmer :)
and replace lines (9-14) with only two lines of code:
session[:user_id] = user.id if user
redirect_to root_path
|
Hey Lisa, Keep with your good work💪💪💪 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solo project by Lisa Rolczynski.